Skip to content

model [nfc]: Comment on lack of [AutocompleteViewManager.dispose] #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnprice merged 1 commit into from
May 7, 2024
Merged

model [nfc]: Comment on lack of [AutocompleteViewManager.dispose] #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/model/autocomplete.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,13 @@ class AutocompleteViewManager {
view.reassemble();
}
}

// No `dispose` method, because there's nothing for it to do.
// The [MentionAutocompleteView]s are owned by (i.e., they get [dispose]d by)
// the UI code that manages the autocomplete interaction, including in the
// case where the [PerAccountStore] is replaced. Discussion:
// https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.60MentionAutocompleteView.2Edispose.60/near/1791292
// void dispose() { … }
}

/// A view-model for a mention-autocomplete interaction.
Expand Down