docs: Port notif and dev-server instructions from legacy app#2265
Open
gnprice wants to merge 5 commits intozulip:mainfrom
Open
docs: Port notif and dev-server instructions from legacy app#2265gnprice wants to merge 5 commits intozulip:mainfrom
gnprice wants to merge 5 commits intozulip:mainfrom
Conversation
This is something we occasionally need to do with the new app,
just like we did with the old app.
The instructions basically carry over unchanged. (Which is one
reason we were never in a rush to port these over; we'd just point
people to the instructions in the old repo when relevant.)
So these files are copied verbatim from the old repo, except in
the one spot that needed editing: the "log in" step at the end.
The old instructions say to use the dev auth method, and we've
never yet gotten around to building that for this app.
To see the diff, use `git diff --no-index`, something like this:
$ git diff --no-index {../mobile/,}docs/howto/dev-server.md
Similar story to the other docs in the parent commit, but this one requires a bit more adaptation. The most substantive set of edits is called out in the text: the "setting the iOS build number" subsection had some details that are different here.
When I was rereading this doc to see where it needed updates and got to this section, I initially thought it was entirely obsolete: our current solution already involves using an appropriate dev certificate to send notifications etc., and those "open questions" have been answered. Reading further, though, it's just incompletely updated: there are still useful improvements that would be useful to make. So update it more fully.
This is a different sort of update that wasn't in the legacy app's version of this document, but wasn't essential for correctness so I left it out of the initial port commit.
… today When I tried these instructions today, I ran into each of these situations and then got it working. (The different bundle ID was because the APNs certificate I had lying around was for `com.zulip.flutter`, from before the app's launch last year. That might be less likely for anyone to hit in the future; but it could be pretty confusing if you don't know what "topic" means here, so write it down in case it does occur.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like with the old app, we sometimes need to test notifications changes and/or test with a dev server.
The old app's instructions for those (found here) basically work, with very few changes, which is one reason we haven't gotten around to porting them over to here until now. Seems like time to do so, though.
From #2156 it sounds like the existing
push-notifications-ios-simulator.mdwill no longer be useful after E2EE notifications #1764. @rajveermalviya is that right? (Same question as at #2156 (comment) .) If those instructions will remain useful, then we'll want to stitch in a reference to them from the newly-ported file; if not, we'll be deleting them soon anyway.