changelog: Describe changes since 30.0.270#2198
Conversation
aea670a to
5e7bec5
Compare
gnprice
left a comment
There was a problem hiding this comment.
Thanks for preparing this! Comments below.
One general principle that I don't think I'd articulated: the user-visible changes mentioned in the merge log have two purposes:
- They serve as input to preparing the highlights for users.
- They give us something to refer to when we're curious about some change in the app's behavior and what to know which release introduced it.
So that second point serves as background for the items below where I ask for additional mentions there (for Flutter/deps upgrades, and for server-visible changes).
docs/changelog.md
Outdated
| * #2084: fix #1798. Show the Refresh/Subscribe banner in unsubscribed | ||
| channels even when you have permission to send messages. |
There was a problem hiding this comment.
This was in the previous release, right?
docs/changelog.md
Outdated
| * (Android) We now show your organization's name instead of its URL | ||
| in notifications, with Zulip Server 8+. (#570) |
There was a problem hiding this comment.
| * (Android) We now show your organization's name instead of its URL | |
| in notifications, with Zulip Server 8+. (#570) | |
| * (Android) We now show your organization's name instead of its URL | |
| in notifications. (#570) |
We don't officially support older versions than that anyway; so no need to add a qualifier and have people wondering if it applies to them.
There was a problem hiding this comment.
We support 7.x servers:
/// The Zulip Server version below which we should refuse to connect.
///
/// When updating this, also update [kMinSupportedZulipFeatureLevel]
/// and the README.
// TODO(#1838) address all TODO(server-7)
const kMinSupportedZulipVersion = '7.0';
/// The Zulip feature level reserved for the [kMinSupportedZulipVersion] release.
///
/// For this value, see the API changelog:
/// https://zulip.com/api/changelog
const kMinSupportedZulipFeatureLevel = 185;There was a problem hiding this comment.
We don't yet cause the app to stop working at those versions, but we only officially support versions from the last 18 months:
https://zulip.readthedocs.io/en/stable/overview/release-lifecycle.html#client-apps
I think there are probably very few people using server versions older than 8, but a large number of people who don't know what version the server they're using is on and don't know whether 8 is an old or a very new version.
| * #2043: fix #1567. Fixed a bug on Android where sometimes | ||
| opening a notification wouldn't navigate to the conversation. |
There was a problem hiding this comment.
This was a pretty annoying issue for some folks, so I think definitely a highlight.
| * #2155 | ||
| * #1882: fix #1558. When we can't load a user's avatar, | ||
| show a generic placeholder. | ||
| * #2125: fix #894. Handle flags for @-topic mentions. |
There was a problem hiding this comment.
not a user-visible change, except on possible future servers (see commit, 348c4fa)
There was a problem hiding this comment.
(fine to note this, but should make clear it's only future-proofing, because otherwise it sounds like it has some sort of effect now)
docs/changelog.md
Outdated
| ### Highlights for developers | ||
|
|
||
| * Merge log: PRs, with fixed issues and user-visible changes. | ||
| * #2103 |
There was a problem hiding this comment.
This is a Flutter upgrade; I've been noting those here because they may well have user-visible effects (even if we haven't identified a specific one).
| * #2140 | ||
| * #2141 |
docs/changelog.md
Outdated
| * #2135 | ||
| * #2145 | ||
| * #2134 | ||
| * #2129 |
| * #2175: fix #1260. Show translated user-facing strings for @-mentions | ||
| of system groups. | ||
| * #2171: Set up Patrol for integration tests. | ||
| * #2176 |
There was a problem hiding this comment.
#2176 isn't exactly user-visible, but it is server-visible: it causes device registration. So it'd be good to mention here, because that change is something we could potentially end up wanting to know which release introduced (when investigating changes we see happening from the server side).
5e7bec5 to
c42699c
Compare
|
Thanks for the review! Revision pushed. |
docs/changelog.md
Outdated
| * (Android) We now show your organization's name instead of its URL | ||
| in notifications, with Zulip Server 8+. (#570) |
There was a problem hiding this comment.
We don't yet cause the app to stop working at those versions, but we only officially support versions from the last 18 months:
https://zulip.readthedocs.io/en/stable/overview/release-lifecycle.html#client-apps
I think there are probably very few people using server versions older than 8, but a large number of people who don't know what version the server they're using is on and don't know whether 8 is an old or a very new version.
docs/changelog.md
Outdated
| * #2176: Tracks push-device data from servers in the E2EE-notification | ||
| protocol. |
There was a problem hiding this comment.
The key info here is what the server operator can see (since there's no behavior the user can see). That part is:
| * #2176: Tracks push-device data from servers in the E2EE-notification | |
| protocol. | |
| * #2176: Register client device with server. |
There was a problem hiding this comment.
But #2176 doesn't do that, as I mentioned in #2198 (comment) . Aren't we awaiting that in #2181 (not yet merged)?
There was a problem hiding this comment.
Ah sorry, I missed that comment. (GitHub did the thing where the page updated to show your main comment, and your revision, but not your replies to the subthreads above.)
Yeah, that's right. I was scanning the git log --oneline for the whole sequence since the last release, and probably I saw this:
70fa425 api: Add route registerClientDevice
and confused it with the step in #2181 where we actually start calling that route.
I don't think there's any server-visible behavior in us tracking the device data either: the server is sending us that data in the initial snapshot and in events either way, and the change is just that we parse it and have data structures tracking it. So this can go back to just the bare PR number, then.
There was a problem hiding this comment.
Ah I think I misspoke above with
Tracking push-device data is server-visible
I was looking for your intended meaning, i.e. maybe a functional change in #2176 that you wanted to call out but that you misremembered as being the POST /register_client_device call.
There is a functional change in #2176 (involving server behavior), but of a kind we probably don't need to call out here: it adds exposure to validation errors when we consume the initial snapshot and events.
There was a problem hiding this comment.
Ah and I wrote my comment 8 minutes ago without GitHub ever hinting that you had replied 🥲—anyway, yes, I'll do this:
So this can go back to just the bare PR number, then.
c42699c to
cda591a
Compare
|
Thanks for the review! Revision pushed, resolving the above and also adding #2195 to the merge log since it landed after my last revision. It's a user-visible change (so I've added words for it in the merge log) but not a feature we need to highlight for users. |
|
Thanks! Looks good; merging, with one nit fix: - * #2129: Flutter and package upgrades.
+ * #2129: Flutter and package upgrades.(trailing space) |
|
Oh and one other: (same convention as previous such updates) |
cda591a to
51493b3
Compare
No description provided.