ci: Pin Flutter to the version we use in release, hackily for now#2138
Merged
gnprice merged 1 commit intozulip:mainfrom Feb 13, 2026
Merged
ci: Pin Flutter to the version we use in release, hackily for now#2138gnprice merged 1 commit intozulip:mainfrom
gnprice merged 1 commit intozulip:mainfrom
Conversation
gnprice
force-pushed
the
pr-ci
branch
2 times, most recently
from
8b7bf6e to
1e71388
Compare
Our CI is broken at the moment because of changes in recent Flutter commits upstream. Usually we'd just upgrade to the latest and make any corresponding updates in our code. That's blocked for a couple of reasons, including a change in the Android embedding: zulip#2129 (comment) While that's still getting resolved, fix CI by having it run on the same version that's in a comment in pubspec.yaml, which is the version we'd use when making a release. Earlier today on a pairing call, Rajesh and I developed a version of this that's more cleanly organized, including some refactoring. He hasn't yet sent that branch as a PR, though, and it's night-time for him now. I'll still be glad to have that refactoring, but the immediate priority is to get the CI fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CI is broken at the moment because of changes in recent Flutter commits upstream. Usually we'd just upgrade to the latest and make any corresponding updates in our code. That's blocked for a couple of reasons, including a change in the Android embedding:
#2129 (comment)
While that's still getting resolved, fix CI by having it run on the same version that's in a comment in pubspec.yaml, which is the version we'd use when making a release.
Earlier today on a pairing call, @rajveermalviya and I developed a version of this that's more cleanly organized, including some refactoring. He hasn't yet sent that branch as a PR, though, and it's night-time for him now. I'll still be glad to have that refactoring, but the immediate priority is to get the CI fixed.
Also filed #2139 to track doing the upgrade and resolving this hack.