content: Add `GroupMention` to render user group mentions dynamically by Ruhdee · Pull Request #2119 · zulip/zulip-flutter

Ruhdee · 2026-02-04T20:37:43Z

Before	After

Changes Made:

Added sealed class 'MentionNode' and refactored variables, cleaned comments accordingly.
Added 'GroupMentionNode' class
Added 'GroupMention' Widget. Created this separate widget instead of keeping the singular UserMention widget to introduce changes in the future (content: Distinguish direct and wildcard mentions #646 will introduce separate styling, maybe in the future, user group mentions might become tappable, etc.). It is also in line with the sealed class implementation.
Updated and added tests

Doubts:

Between the 2nd and 3rd commits, I have made a temporary implementation of GroupMentionNode case and added a TODO comment in the content widget file to separate the commits. Is this practice correct?
In 1st commit, I have fixed one old comment (description of TODO issue 646) in the content widget file. Is that the way to change old comments that might be incorrect?

rajveermalviya

Thanks for working on this @Ruhdee! Overall looks good, some small comments below.

lib/model/content.dart

test/model/content_test.dart

lib/widgets/content.dart

Ruhdee · 2026-02-06T18:25:03Z

@rajveermalviya Thank you for the review! I have addressed the feedback. PTAL.

rajveermalviya

Thanks for the revision @Ruhdee! All looks good, modulo one nit.

Moving over to Greg's review.

lib/widgets/content.dart

Ruhdee · 2026-02-08T19:47:46Z

I have made the latest requested change.

gnprice

Thanks @Ruhdee for taking care of this, and thanks @rajveermalviya for the previous reviews!

Generally this looks great. Various small comments below, mostly nits.

lib/widgets/content.dart

lib/model/content.dart

gnprice · 2026-02-09T21:02:11Z

lib/model/content.dart

+      final userId = switch (element.attributes['data-user-id']) {
+        // For legacy or wildcard mentions.
+        null || '*' => null,
+        final userIdString => int.tryParse(userIdString),


Ah, and I see this existing call is missing radix: 10. So that would be good to fix as a separate prep commit.

Since this change affects the behaviour of the function in case 'data-user-id' is a hexadecimal, this change technically counts as a functional change, right?

That's right, it's not an NFC commit. It's nearly NFC, in that it's NFC on the assumption of a well-behaved server.

lib/widgets/content.dart

Ruhdee · 2026-02-10T16:34:01Z

I have addressed all the feedback. @gnprice PTAL.
Why CI is failing: #2129 (comment)

Ruhdee · 2026-02-13T18:59:41Z

CI is now passing

gnprice

Thanks for the revision! Just a handful of comments below. Also replied to a question above: #2119 (comment)

lib/widgets/content.dart

Ruhdee · 2026-02-14T07:42:31Z

I have addressed the feedback. PTAL.

gnprice · 2026-02-17T23:55:35Z

Thanks! Looks great; merging.

Deleted enum 'UserMentionType' and outdated comments. Refactored 'parseUserMention' and changed it's return type to 'MentionNode'. Renamed '_userMentionClassNameRegexp'.

…cally Fixes zulip#1259. Look up current user group name from PerAccountStore when rendering mentions, while respecting 'isSilent' flag. This ensures mentions display correctly even if the user group name has been changed since the message was sent. Falls back to original HTML text when user group not found. Added 'user group mention dynamic name resolution' tests group.

gnprice added the maintainer review PR ready for review by Zulip maintainers label Feb 5, 2026

gnprice requested a review from rajveermalviya February 5, 2026 01:55

rajveermalviya self-assigned this Feb 6, 2026

rajveermalviya requested changes Feb 6, 2026

View reviewed changes

Ruhdee force-pushed the issue-1259 branch 7 times, most recently from 71538c1 to b2408e8 Compare February 6, 2026 18:22

Ruhdee requested a review from rajveermalviya February 6, 2026 18:25

rajveermalviya approved these changes Feb 8, 2026

View reviewed changes

lib/widgets/content.dart Show resolved Hide resolved

rajveermalviya added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Feb 8, 2026

rajveermalviya assigned gnprice and unassigned rajveermalviya Feb 8, 2026

rajveermalviya requested a review from gnprice February 8, 2026 18:03

Ruhdee force-pushed the issue-1259 branch from b2408e8 to 636267f Compare February 8, 2026 19:44

gnprice reviewed Feb 9, 2026

View reviewed changes

Ruhdee force-pushed the issue-1259 branch 6 times, most recently from 77f3ce7 to 66a7186 Compare February 10, 2026 16:08

Ruhdee requested a review from gnprice February 10, 2026 16:30

Ruhdee marked this pull request as draft February 13, 2026 18:21

Ruhdee marked this pull request as ready for review February 13, 2026 18:21

Ruhdee force-pushed the issue-1259 branch from 66a7186 to f8c404d Compare February 13, 2026 18:22

gnprice reviewed Feb 13, 2026

View reviewed changes

lib/widgets/content.dart Show resolved Hide resolved

lib/widgets/content.dart Outdated Show resolved Hide resolved

Ruhdee force-pushed the issue-1259 branch from f8c404d to 4b7a2bf Compare February 14, 2026 07:30

Ruhdee requested a review from gnprice February 14, 2026 07:42

Ruhdee added 6 commits February 17, 2026 15:55

content [nfc]: Fix TODO comment in UserMention widget code

5c27c6a

content: Fix usage of int.tryParse by adding radix: 10

7e37f82

content [nfc]: Add sealed base class MentionNode

7d842a4

Deleted enum 'UserMentionType' and outdated comments. Refactored 'parseUserMention' and changed it's return type to 'MentionNode'. Renamed '_userMentionClassNameRegexp'.

content [nfc]: Rename UserMention widget to Mention

1a6c314

content: Add UserGroupMentionNode and update parseMention

146afe2

gnprice force-pushed the issue-1259 branch from 4b7a2bf to f239c88 Compare February 17, 2026 23:57

gnprice merged commit f239c88 into zulip:main Feb 17, 2026

This was referenced Feb 19, 2026

content: Distinguish direct and wildcard mentions #646

Closed

Handle system-group names in rendering @-mentions #1260

Closed

Conversation

Ruhdee commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rajveermalviya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ruhdee commented Feb 6, 2026

Uh oh!

rajveermalviya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Ruhdee commented Feb 8, 2026

Uh oh!

gnprice left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gnprice Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Ruhdee Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gnprice Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ruhdee commented Feb 10, 2026

Uh oh!

Ruhdee commented Feb 13, 2026

Uh oh!

gnprice left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Ruhdee commented Feb 14, 2026

Uh oh!

gnprice commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ruhdee commented Feb 4, 2026 •

edited

Loading

Ruhdee Feb 10, 2026 •

edited

Loading