content: Record href and src straightforwardly on ImagePreviewNode#2077

Merged

gnprice merged 21 commits intozulip:mainfrom

chrisbobbe:pr-inline-image-prep

Jan 24, 2026

Commits on Jan 23, 2026

content [nfc]: Repeat UnimplementedBlockContentNode less
chrisbobbe
committed
content: For image previews, assert img has `src` even in loading case
chrisbobbe
committed
content test: Add some more image-preview examples, and more comments
chrisbobbe
committed
content test: Test explicitly what we do with src/href in image previews
chrisbobbe
committed
content test: Remove some now-redundant tests
chrisbobbe
committed
content: Merge ImagePreviewNode calls across branches of `loading` bool
chrisbobbe
committed
content [nfc]: Cut a vague TODO about a "hover animation"
chrisbobbe
committed
image [nfc]: Fix return type of ImageThumbnailLocatorExtension.resolve
chrisbobbe
committed
content [nfc]: s/resolvedSrcUrl/lightboxDisplayUrl/
chrisbobbe
committed
content [nfc]: Factor a nested conditional as a switch/case
chrisbobbe
committed
content [nfc]: Move a TODO and add issue number; add some missing TODOs
chrisbobbe
committed
content: Stop dropping LightboxHero in a case where we offer the lightbox
chrisbobbe
committed
content [nfc]: Pull out a `child` variable in MessageImagePreview.build
chrisbobbe
committed
content [nfc]: Compute `child` in two steps
chrisbobbe
committed
content [nfc]: Early return when we don't have a URL for the lightbox
chrisbobbe
committed
content [nfc]: Move second step of child computation downward
chrisbobbe
committed
content [nfc]: Spell out some logic more explicitly
chrisbobbe
committed
content: Show thumbnail in image preview even if original URL didn't parse
chrisbobbe
committed
content [nfc]: Define lightboxDisplayUrl lower, just above its null check
chrisbobbe
committed
content [nfc]: Inline srcUrl and thumbnailLocator
chrisbobbe
committed
content [nfc]: Record href and src straightforwardly on ImagePreviewNode
chrisbobbe
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

content: Record href and src straightforwardly on ImagePreviewNode#2077

content: Record href and src straightforwardly on ImagePreviewNode#2077
gnprice merged 21 commits intozulip:mainfrom
chrisbobbe:pr-inline-image-prep

Commits on Jan 23, 2026

content [nfc]: Repeat UnimplementedBlockContentNode less

content: For image previews, assert img has `src` even in loading case

content test: Add some more image-preview examples, and more comments

content test: Test explicitly what we do with src/href in image previews

content test: Remove some now-redundant tests

content: Merge ImagePreviewNode calls across branches of `loading` bool

content [nfc]: Cut a vague TODO about a "hover animation"

image [nfc]: Fix return type of ImageThumbnailLocatorExtension.resolve

content [nfc]: s/resolvedSrcUrl/lightboxDisplayUrl/

content [nfc]: Factor a nested conditional as a switch/case

content [nfc]: Move a TODO and add issue number; add some missing TODOs

content: Stop dropping LightboxHero in a case where we offer the lightbox

content [nfc]: Pull out a `child` variable in MessageImagePreview.build

content [nfc]: Compute `child` in two steps

content [nfc]: Early return when we don't have a URL for the lightbox

content [nfc]: Move second step of child computation downward

content [nfc]: Spell out some logic more explicitly

content: Show thumbnail in image preview even if original URL didn't parse

content [nfc]: Define lightboxDisplayUrl lower, just above its null check

content [nfc]: Inline srcUrl and thumbnailLocator

content [nfc]: Record href and src straightforwardly on ImagePreviewNode