Add Semantics labels to loading indicators and update related tests #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the Pull Request, I can provide some insights on this PR as a contributor just like you. |
lib/widgets/action_sheet.dart
Outdated
| ? CircularProgressIndicator() | ||
| : Text( | ||
| ? Semantics( | ||
| label: 'Loading…', |
Contributor
There was a problem hiding this comment.
Please make sure not to insert hardcoded strings and instead use the zulip localization to fetch those from app_en.arb, this helps zulip to make the app available to user across the globe with different languages.
lib/widgets/message_list.dart
Outdated
Comment on lines
1040
to
1043
| child: const CircularProgressIndicator(), | ||
| ), | ||
| ), | ||
| ); |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| child: const CircularProgressIndicator(), | |
| ), | |
| ), | |
| ); | |
| child: const CircularProgressIndicator()))); |
See in this file (and other examples across the codebase).
lib/widgets/topic_list.dart
Outdated
Comment on lines
176
to
179
| child: CircularProgressIndicator(), | ||
| ), | ||
| ), | ||
| ); |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| child: CircularProgressIndicator(), | |
| ), | |
| ), | |
| ); | |
| child: CircularProgressIndicator()))); |
lib/widgets/home.dart
Outdated
| children: [ | ||
| const CircularProgressIndicator(), | ||
| Semantics( | ||
| label: 'Loading…', |
lib/widgets/topic_list.dart
Outdated
| padding: const EdgeInsets.symmetric(vertical: 16.0), | ||
| child: Semantics( | ||
| textDirection: Directionality.of(context), | ||
| label: 'Loading…', // plain string (not localized) |
lib/widgets/message_list.dart
Outdated
| child: Padding( | ||
| padding: const EdgeInsets.symmetric(vertical: 16.0), | ||
| child: Semantics( | ||
| label: 'Loading more messages', |
Contributor
There was a problem hiding this comment.
Use ZulipLocalization.
lib/widgets/message_list.dart
Outdated
Comment on lines
1305
to
1306
| child: CircularProgressIndicator(), | ||
| ))); // TODO perhaps a different indicator |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| child: CircularProgressIndicator(), | |
| ))); // TODO perhaps a different indicator | |
| child: CircularProgressIndicator()))); // TODO perhaps a different indicator |
Author
|
Thanks for taking the time to review this! @MritunjayTiwari14 .I’ll implement the changes you recommended and update the branch. |
Add a localized 'loading' label in multiple widgets and apply it consistently across the UI. Update ARB files and regenerate localization outputs. Update widget tests to use the localized semantics label instead of hardcoded strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1962
This PR improves accessibility by adding
Semanticswidgets around loadingindicators so screen readers (TalkBack / VoiceOver) announce that the app is
loading content.
What’s changed
CircularProgressIndicator(and similar loading states) in:Semantics(label: 'Loading…', liveRegion: true)Why
Screen readers were not able to focus on or announce the loading state,
making the app inaccessible while fetching messages or topics.
Testing
-Verified that find.bySemanticsLabel(...) correctly locates the loading indicators.
-Ensured no regressions in navigation or layout.
-flutter analyze reports no new warnings.
Screenshot (TalkBack focus on loading indicator)
This shows the loading indicator now exposes an accessible label via
Semantics().Notes
this new PR contains only the intended accessibility changes.
Related
Replaces the earlier PR (#2017) with a clean version.