Skip to content

action_sheet: Use directional border radius for reaction buttons #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

action_sheet: Use directional border radius for reaction buttons #2010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/widgets/action_sheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,11 +1229,12 @@ class ReactionButtons extends StatelessWidget {
required bool isFirst,
}) {
final designVariables = DesignVariables.of(context);
final textDirection = Directionality.of(context);
return Flexible(child: InkWell(
onTap: () => _handleTapReaction(emoji: emoji, isSelfVoted: isSelfVoted),
splashFactory: NoSplash.splashFactory,
borderRadius: isFirst
? const BorderRadius.only(topLeft: Radius.circular(7))
? const BorderRadiusDirectional.only(topStart: Radius.circular(7)).resolve(textDirection)
: null,
overlayColor: WidgetStateColor.resolveWith((states) =>
states.any((e) => e == WidgetState.pressed)
Expand All @@ -1253,6 +1254,7 @@ class ReactionButtons extends StatelessWidget {

@override
Widget build(BuildContext context) {
final textDirection = Directionality.of(context);
final store = PerAccountStoreWidget.of(pageContext);
final popularEmojiCandidates = store.popularEmojiCandidates();
assert(popularEmojiCandidates.every(
Expand Down Expand Up @@ -1289,7 +1291,7 @@ class ReactionButtons extends StatelessWidget {
InkWell(
onTap: _handleTapMore,
splashFactory: NoSplash.splashFactory,
borderRadius: const BorderRadius.only(topRight: Radius.circular(7)),
borderRadius: const BorderRadiusDirectional.only(topEnd: Radius.circular(7)).resolve(textDirection),
overlayColor: WidgetStateColor.resolveWith((states) =>
states.any((e) => e == WidgetState.pressed)
? designVariables.contextMenuItemBg.withFadedAlpha(0.20)
Expand Down