Upgrade Flutter and packages #2009
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And update Flutter's supporting libraries to match.
This commit is the result of the following commands: flutter pub upgrade --major-versions firebase_messaging firebase_core tools/upgrade pod Changelogs: https://pub.dev/packages/firebase_core/changelog#421 https://pub.dev/packages/firebase_messaging/changelog#1604 No notable changes for both of these packages.
This commit is the result of the following commands: flutter pub upgrade --major-versions pigeon tools/check --all-files --fix pigeon Changelog: https://pub.dev/packages/pigeon/changelog#2612 There is one bug fix related to `InstanceManager` which seems to be used for `@ProxyApi`, which we do not use it.
Changelog: https://pub.dev/packages/http/changelog#160 One breaking change which now omits `charset` parameter for all media types except for `text` and some `application/xml` types: https://github.com/dart-lang/http/blob/a22386e9c/pkgs/http/lib/src/request.dart#L18-L31 dart-lang/http#1798 That breaks some of our tests which expect `charset=utf-8` being present in the `Content-Type` header, so this commit includes a fix for those tests, simply removing that expectation. The default charset still remains `utf-8`: https://github.com/dart-lang/http/blob/a22386e9c/pkgs/http/lib/src/request.dart#L179
Collaborator
|
Thanks! LGTM, and looks OK with a quick manual smoke test on an iOS simulator; marking for Greg's review. |
chrisbobbe
added
the
integration review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter notable commits
Still doesn't include a fix for #918 because even if we use the
mainbranch from upstream repo, there is another issue of a method not being implemented: james-alex/color_models#14.And same for #437, because there still doesn't seem to be support for filtering
fontentires in pubspec.yaml yet, only assets: flutter/flutter#176393.