Skip to content

settings: Add scroll for settings page #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −1
Open

settings: Add scroll for settings page #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/widgets/settings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class SettingsPage extends StatelessWidget {
return Scaffold(
appBar: ZulipAppBar(
title: Text(zulipLocalizations.settingsPageTitle)),
body: Column(children: [
body: ListView(children: [
const _ThemeSetting(),
const _BrowserPreferenceSetting(),
const _VisitFirstUnreadSetting(),
Expand Down
18 changes: 18 additions & 0 deletions test/widgets/settings_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,24 @@ void main() {
}, variant: TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
});

group('SettingPageScrollBehavior', () {
testWidgets('scroll settings list when screen size is small', (tester) async {
tester.view.physicalSize = const Size(200, 200);
tester.view.devicePixelRatio = 1.0;
addTearDown(tester.view.reset);
await prepare(tester);

final lastElementFinder = GlobalSettingsStore.experimentalFeatureFlags.isNotEmpty
? find.text("Experimental features")
: find.text("Mark messages as read on scroll");
check(lastElementFinder.evaluate().isEmpty).equals(true);

await tester.scrollUntilVisible(lastElementFinder, 100,
scrollable: find.byType(Scrollable));
check(lastElementFinder.evaluate().isEmpty).equals(false);
});
});

group('VisitFirstUnreadSetting', () {
String settingTitle(VisitFirstUnreadSetting setting) => switch (setting) {
VisitFirstUnreadSetting.always => 'First unread message',
Expand Down