channel [nfc]: s/hasPostingPermission/selfCanSendMessage/; assume self-user #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Thanks @chrisbobbe! LGTM, also I see that there are some conflicts.
rajveermalviya
added
the
integration review
rajveermalviya
removed
the
maintainer review
…f-user This new name aligns better with the API's naming of the modern group-based permission, can_send_message_group, which we might implement soon.
|
Thanks! Looks good; merging. |
gnprice
force-pushed
the
pr-self-can-send-message
branch
from
35abf84 to
da1d968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new name aligns better with the API's naming of the modern group-based permission, can_send_message_group, which we might implement soon.