-
Notifications
You must be signed in to change notification settings - Fork 350
Upgrade Flutter, packages and Android build dependencies #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f765840
2453ae7
b6084e0
836f1d0
f09116a
7e791ac
144a888
277fc97
c6fcbf6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # This should match the iOS Deployment Target | ||
| # (in Xcode, that's in project > Runner > Info) | ||
| # and MinimumOSVersion in ios/Flutter/AppFrameworkInfo.plist. | ||
| platform :ios, '14.0' | ||
| platform :ios, '15.0' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: let's explain a bit more in the commit message why this upgrade is OK. See the last such update, in a7ed31e. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I also went and did a fresh round of those platform-version statistics. So you can link to this message: |
||
|
|
||
| # CocoaPods analytics sends network stats synchronously affecting flutter build latency. | ||
| ENV['COCOAPODS_DISABLE_STATS'] = 'true' | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,33 +37,33 @@ PODS: | |
| - file_picker (0.0.1): | ||
| - DKImagePickerController/PhotoGallery | ||
| - Flutter | ||
| - Firebase/CoreOnly (11.15.0): | ||
| - FirebaseCore (~> 11.15.0) | ||
| - Firebase/Messaging (11.15.0): | ||
| - Firebase/CoreOnly (12.0.0): | ||
| - FirebaseCore (~> 12.0.0) | ||
| - Firebase/Messaging (12.0.0): | ||
| - Firebase/CoreOnly | ||
| - FirebaseMessaging (~> 11.15.0) | ||
| - firebase_core (3.15.1): | ||
| - Firebase/CoreOnly (= 11.15.0) | ||
| - FirebaseMessaging (~> 12.0.0) | ||
| - firebase_core (4.0.0): | ||
| - Firebase/CoreOnly (= 12.0.0) | ||
| - Flutter | ||
| - firebase_messaging (15.2.9): | ||
| - Firebase/Messaging (= 11.15.0) | ||
| - firebase_messaging (16.0.0): | ||
| - Firebase/Messaging (= 12.0.0) | ||
| - firebase_core | ||
| - Flutter | ||
| - FirebaseCore (11.15.0): | ||
| - FirebaseCoreInternal (~> 11.15.0) | ||
| - FirebaseCore (12.0.0): | ||
| - FirebaseCoreInternal (~> 12.0.0) | ||
| - GoogleUtilities/Environment (~> 8.1) | ||
| - GoogleUtilities/Logger (~> 8.1) | ||
| - FirebaseCoreInternal (11.15.0): | ||
| - FirebaseCoreInternal (12.0.0): | ||
| - "GoogleUtilities/NSData+zlib (~> 8.1)" | ||
| - FirebaseInstallations (11.15.0): | ||
| - FirebaseCore (~> 11.15.0) | ||
| - FirebaseInstallations (12.0.0): | ||
| - FirebaseCore (~> 12.0.0) | ||
| - GoogleUtilities/Environment (~> 8.1) | ||
| - GoogleUtilities/UserDefaults (~> 8.1) | ||
| - PromisesObjC (~> 2.4) | ||
| - FirebaseMessaging (11.15.0): | ||
| - FirebaseCore (~> 11.15.0) | ||
| - FirebaseInstallations (~> 11.0) | ||
| - GoogleDataTransport (~> 10.0) | ||
| - FirebaseMessaging (12.0.0): | ||
| - FirebaseCore (~> 12.0.0) | ||
| - FirebaseInstallations (~> 12.0.0) | ||
| - GoogleDataTransport (~> 10.1) | ||
| - GoogleUtilities/AppDelegateSwizzler (~> 8.1) | ||
| - GoogleUtilities/Environment (~> 8.1) | ||
| - GoogleUtilities/Reachability (~> 8.1) | ||
|
|
@@ -117,28 +117,31 @@ PODS: | |
| - SDWebImage/Core (5.21.1) | ||
| - share_plus (0.0.1): | ||
| - Flutter | ||
| - sqlite3 (3.50.1): | ||
| - sqlite3/common (= 3.50.1) | ||
| - sqlite3/common (3.50.1) | ||
| - sqlite3/dbstatvtab (3.50.1): | ||
| - sqlite3 (3.50.4): | ||
| - sqlite3/common (= 3.50.4) | ||
| - sqlite3/common (3.50.4) | ||
| - sqlite3/dbstatvtab (3.50.4): | ||
| - sqlite3/common | ||
| - sqlite3/fts5 (3.50.1): | ||
| - sqlite3/fts5 (3.50.4): | ||
| - sqlite3/common | ||
| - sqlite3/math (3.50.1): | ||
| - sqlite3/math (3.50.4): | ||
| - sqlite3/common | ||
| - sqlite3/perf-threadsafe (3.50.1): | ||
| - sqlite3/perf-threadsafe (3.50.4): | ||
| - sqlite3/common | ||
| - sqlite3/rtree (3.50.1): | ||
| - sqlite3/rtree (3.50.4): | ||
| - sqlite3/common | ||
| - sqlite3/session (3.50.4): | ||
| - sqlite3/common | ||
| - sqlite3_flutter_libs (0.0.1): | ||
| - Flutter | ||
| - FlutterMacOS | ||
| - sqlite3 (~> 3.50.1) | ||
| - sqlite3 (~> 3.50.3) | ||
| - sqlite3/dbstatvtab | ||
| - sqlite3/fts5 | ||
| - sqlite3/math | ||
| - sqlite3/perf-threadsafe | ||
| - sqlite3/rtree | ||
| - sqlite3/session | ||
| - SwiftyGif (5.4.5) | ||
| - url_launcher_ios (0.0.1): | ||
| - Flutter | ||
|
|
@@ -220,13 +223,13 @@ SPEC CHECKSUMS: | |
| DKImagePickerController: 946cec48c7873164274ecc4624d19e3da4c1ef3c | ||
| DKPhotoGallery: b3834fecb755ee09a593d7c9e389d8b5d6deed60 | ||
| file_picker: a0560bc09d61de87f12d246fc47d2119e6ef37be | ||
| Firebase: d99ac19b909cd2c548339c2241ecd0d1599ab02e | ||
| firebase_core: ece862f94b2bc72ee0edbeec7ab5c7cb09fe1ab5 | ||
| firebase_messaging: e1a5fae495603115be1d0183bc849da748734e2b | ||
| FirebaseCore: efb3893e5b94f32b86e331e3bd6dadf18b66568e | ||
| FirebaseCoreInternal: 9afa45b1159304c963da48addb78275ef701c6b4 | ||
| FirebaseInstallations: 317270fec08a5d418fdbc8429282238cab3ac843 | ||
| FirebaseMessaging: 3b26e2cee503815e01c3701236b020aa9b576f09 | ||
| Firebase: 800d487043c0557d9faed71477a38d9aafb08a41 | ||
| firebase_core: 633e1851ffe1b9ab875f6467a4f574c79cef02e4 | ||
| firebase_messaging: d17feef781edc84ebefe62624fb384358ad96361 | ||
| FirebaseCore: 055f4ab117d5964158c833f3d5e7ec6d91648d4a | ||
| FirebaseCoreInternal: dedc28e569a4be85f38f3d6af1070a2e12018d55 | ||
| FirebaseInstallations: d4c7c958f99c8860d7fcece786314ae790e2f988 | ||
| FirebaseMessaging: af49f8d7c0a3d2a017d9302c80946f45a7777dde | ||
| Flutter: cabc95a1d2626b1b06e7179b784ebcf0c0cde467 | ||
| GoogleDataTransport: aae35b7ea0c09004c3797d53c8c41f66f219d6a7 | ||
| GoogleUtilities: 00c88b9a86066ef77f0da2fab05f65d7768ed8e1 | ||
|
|
@@ -238,13 +241,13 @@ SPEC CHECKSUMS: | |
| PromisesObjC: f5707f49cb48b9636751c5b2e7d227e43fba9f47 | ||
| SDWebImage: f29024626962457f3470184232766516dee8dfea | ||
| share_plus: 50da8cb520a8f0f65671c6c6a99b3617ed10a58a | ||
| sqlite3: 1d85290c3321153511f6e900ede7a1608718bbd5 | ||
| sqlite3_flutter_libs: e7fc8c9ea2200ff3271f08f127842131746b70e2 | ||
| sqlite3: 73513155ec6979715d3904ef53a8d68892d4032b | ||
| sqlite3_flutter_libs: 616267f2fca40e9c6af8c5d82324e05667040b6e | ||
| SwiftyGif: 706c60cf65fa2bc5ee0313beece843c8eb8194d4 | ||
| url_launcher_ios: 694010445543906933d732453a59da0a173ae33d | ||
| video_player_avfoundation: 2cef49524dd1f16c5300b9cd6efd9611ce03639b | ||
| wakelock_plus: e29112ab3ef0b318e58cfa5c32326458be66b556 | ||
|
|
||
| PODFILE CHECKSUM: 66b7725a92b85e7acc28f0ced0cdacebf18e1997 | ||
| PODFILE CHECKSUM: f23347f4ef610d6b07bcd5d9dc9e3ed75fb84721 | ||
|
Comment on lines
-248
to
+251
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: this line doesn't change in the commit that touches 9d1bd9e ios: Bump min iOS version to 15.0, as required by latest Firebase iOS SDK I think that means this file is inaccurate either before or after that commit. |
||
|
|
||
| COCOAPODS: 1.16.2 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One item in the "Breaking changes and deprecations" section looks relevant:
We do have
kotlinOptionsblocks. But it looks like that error hasn't appeared in our build. Do you know why?There's probably also an upstream Flutter issue about this, since
kotlinOptionsalso appears in the upstreamflutter createtemplates.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these errors are only shown if the script is in Kotlin DSL script, not Groovy. I migrated
build.gradleto Kotlin DSL for testing and got these errors:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, that makes sense, thanks.
I guess migrating our Gradle scripts to Kotlin would be a good thing to do too — it's already happened in the
flutter createtemplates. But that can be a follow-up PR and a separate issue.