new-dm: Exclude deactivated users#1744
Merged
chrisbobbe merged 3 commits intozulip:mainfrom Jul 24, 2025
Merged
Conversation
Member
Author
|
CI failing only with the pair of lint issues fixed in #1739. |
This lets us make it a bit more thorough, while not adding to the complexity of reading the test case for the basic logic.
Potentially this would have helped us avoid the issue zulip#1743.
gnprice
force-pushed
the
pr-dm-deactivated
branch
from
1346a62 to
32a9d0e
Compare
Collaborator
|
Thanks, LGTM! Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1743.