Skip to content

analyze: Fix new lints on latest Flutter main #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnprice merged 2 commits into from
Jul 24, 2025
Merged

analyze: Fix new lints on latest Flutter main #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c3b505
api [nfc]: Remove a comment about event_types that came from outdated…
chrisbobbe Jul 24, 2025
0ce94c4
analyze: Fix new lint on latest Flutter main
chrisbobbe Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/api/model/events.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,10 +1172,7 @@ class UpdateMessageFlagsRemoveEvent extends UpdateMessageFlagsEvent {
factory UpdateMessageFlagsRemoveEvent.fromJson(Map<String, dynamic> json) {
final result = _$UpdateMessageFlagsRemoveEventFromJson(json);
// Crunchy-shell validation
if (
result.flag == MessageFlag.read
&& true // (we assume `event_types` has `message` and `update_message_flags`)
) {
if (result.flag == MessageFlag.read) {
result.messageDetails as Map<int, UpdateMessageFlagsMessageDetail>;
}
return result;
Expand Down
7 changes: 4 additions & 3 deletions lib/model/channel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,10 @@ mixin ChannelStore on UserStore {
case ChannelPostPolicy.any: return true;
case ChannelPostPolicy.fullMembers: {
if (!role.isAtLeast(UserRole.member)) return false;
return role == UserRole.member
? hasPassedWaitingPeriod(user, byDate: byDate)
: true;
if (role == UserRole.member) {
return hasPassedWaitingPeriod(user, byDate: byDate);
}
return true;
}
case ChannelPostPolicy.moderators: return role.isAtLeast(UserRole.moderator);
case ChannelPostPolicy.administrators: return role.isAtLeast(UserRole.administrator);
Expand Down