local echo (6.5/7): Revised prep commits for local echo #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
integration review
gnprice
reviewed
May 29, 2025
Member
gnprice
left a comment
gnprice
left a comment
There was a problem hiding this comment.
Thanks! All looks good except one comment on the last commit. Then please go ahead and merge.
lib/widgets/message_list.dart
Outdated
Comment on lines
1608
to
1623
| true => _RestoreEditMessageGestureDetector( | ||
| messageId: messageId, | ||
| child: Text( |
Member
There was a problem hiding this comment.
This case should also get 4px of bottom padding, right?
(Maybe this change would be clearer as first an NFC commit that just distributes the logic for the bottom padding among the different cases, followed by a commit that removes 2px of padding for the one case where that's intended. Particularly since it sounds like a previous version had a different bug of this flavor which you've fixed already:
[chris: fixed to maintain 4px bottom padding in the common case
where the progress bar is absent]
)
[chris: added tests] Co-authored-by: Chris Bobbe <[email protected]>
[chris: removed unused import] Co-authored-by: Chris Bobbe <[email protected]>
[chris: small formatting/naming changes] Co-authored-by: Chris Bobbe <[email protected]>
Helpers for starting an edit interaction and dealing with the confirmation dialog will be useful as we support retrieving messages not sent.
This migrates the Polish and Russian translations (the only existing non-en locales to translate this) to use the new string as well.
To prepare for adjusting one of the cases from 4px to 2px: zulip#1535 (comment)
This is where the progress bar for outbox messages will go, so this is for consistency with that. Discussion: zulip#1453 (comment) [chris: fixed to maintain 4px bottom padding in the common case where the progress bar is absent] Co-authored-by: Chris Bobbe <[email protected]>
chrisbobbe
force-pushed
the
pr-local-echo-6.5
branch
from
3f8a10d to
5636e72
Compare
Collaborator
Author
|
Thanks for the review! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1453, with some small adjustments.
Here are before/after screenshots for the commit that adjusts padding:
3f8a10d msglist: Put edit-message progress bar in top half of 4px bottom padding