Skip to content

ios: MinimumOSVersion 12.0 to 14.0 in ios/Flutter/AppFrameworkInfo.plist#1494

Merged
gnprice merged 1 commit into
zulip:mainfrom
chrisbobbe:pr-MinimumOSVersion
May 1, 2025
Merged

ios: MinimumOSVersion 12.0 to 14.0 in ios/Flutter/AppFrameworkInfo.plist#1494
gnprice merged 1 commit into
zulip:mainfrom
chrisbobbe:pr-MinimumOSVersion

Conversation

@chrisbobbe
Copy link
Copy Markdown
Collaborator

The Flutter doc on deploying an iOS app says this number should match the deployment target we set in Xcode (which we also specify in ios/Podfile):
https://docs.flutter.dev/deployment/ios#updating-the-apps-deployment-version
; sure, go ahead and update it.

Prompted by noticing that flutter run started bumping it to 13.0 (in flutter/flutter@09d4dabd6; see discussion:
#1489 (comment)
) and realizing that 14.0 is actually what it should be for us.

The Flutter doc on deploying an iOS app says this number should
match the deployment target we set in Xcode (which we also specify
in ios/Podfile):
  https://docs.flutter.dev/deployment/ios#updating-the-apps-deployment-version
; sure, go ahead and update it.

Prompted by noticing that `flutter run` started bumping it to 13.0
(in flutter/flutter@09d4dabd6; see discussion:
  zulip#1489 (comment)
) and realizing that 14.0 is actually what it should be for us.
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label May 1, 2025
@chrisbobbe chrisbobbe requested a review from gnprice May 1, 2025 00:12
@gnprice
Copy link
Copy Markdown
Member

gnprice commented May 1, 2025

Thanks! Looks good; merging.

@gnprice gnprice merged commit 37dc9ea into zulip:main May 1, 2025
1 check failed
@chrisbobbe chrisbobbe deleted the pr-MinimumOSVersion branch May 1, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration review Added by maintainers when PR may be ready for integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants