test [nfc]: Make globalSettings optional on TestGlobalStore#1403
Merged
chrisbobbe merged 1 commit intozulip:mainfrom Mar 12, 2025
Merged
test [nfc]: Make globalSettings optional on TestGlobalStore#1403chrisbobbe merged 1 commit intozulip:mainfrom
chrisbobbe merged 1 commit intozulip:mainfrom
Conversation
This has a natural default, at least in tests, because most tests don't care about the specific value of the global settings. (By contrast most tests that interact with the store at all will care what set of accounts exist, so there isn't as natural a default for `accounts`.) Originally noticed this here: zulip#1386 (comment)
Member
Author
Collaborator
|
Thanks, LGTM! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has a natural default, at least in tests, because most tests don't care about the specific value of the global settings.
(By contrast most tests that interact with the store at all will care what set of accounts exist, so there isn't as natural a default for
accounts.)Originally noticed this here:
#1386 (comment)