ci: Add setup script for running in Flutter "customer testing"#1300
Merged
chrisbobbe merged 1 commit intozulip:mainfrom Jan 23, 2025
Merged
ci: Add setup script for running in Flutter "customer testing"#1300chrisbobbe merged 1 commit intozulip:mainfrom
chrisbobbe merged 1 commit intozulip:mainfrom
Conversation
Earlier I'd tried adding this "apt install" command directly in the test registry, as a "setup" line in the "zulip.test" file: flutter/tests#441 But the Flutter "customer testing" suite gets run in two different environments; and it turns out that not only does the LUCI environment not need this step (the Zulip tests there were working fine right up until they were disabled last week due to the failures in GitHub Actions), but it also doesn't permit it: there's no access to `sudo`: https://discord.com/channels/608014603317936148/1290464157765865552/1331449169830871122 https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20customer_testing/22301/overview Error output (reformatted): Processing ./../../bin/cache/pkg/tests/registry/zulip.test... >> sudo apt install -y libsqlite3-dev | sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper ERROR: Setup command failed: sudo apt install -y libsqlite3-dev So we need this bit of conditional logic too. That makes this a little more complex than fits in a "setup" line in the test registry. So instead let's make this script which we can invoke from there.
Collaborator
|
Thanks, LGTM! Merging. |
gnprice
added a commit
to gnprice/flutter_customer_testing
that referenced
this pull request
Jan 23, 2025
This re-lands 8cf7a67. Difference from previous version: This version has the new setup step do its work only where `sudo` is available (in GitHub Actions), and successfully do nothing where it's unavailable (in LUCI). The step isn't needed in LUCI. The logic lives in a setup script added today to the Zulip tree: zulip/zulip-flutter#1300
8 tasks
auto-submit Bot
pushed a commit
to flutter/tests
that referenced
this pull request
Feb 5, 2025
This re-lands 8cf7a67 / #441. Difference from previous version: This version has the new setup step do its work only where `sudo` is available (in GitHub Actions), and successfully do nothing where it's unavailable (in LUCI). The step isn't needed in LUCI. The logic lives in a setup script added today to the Zulip tree: zulip/zulip-flutter#1300
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier I'd tried adding this "apt install" command directly in the test registry, as a "setup" line in the "zulip.test" file:
flutter/tests#441
But the Flutter "customer testing" suite gets run in two different environments; and it turns out that not only does the LUCI environment not need this step (the Zulip tests there were working fine right up until they were disabled last week due to the failures in GitHub Actions), but it also doesn't permit it: there's no access to
sudo:https://discord.com/channels/608014603317936148/1290464157765865552/1331449169830871122
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20customer_testing/22301/overview
Error output (reformatted):
So we need this bit of conditional logic too. That makes this a little more complex than fits in a "setup" line in the test registry. So instead let's make this script which we can invoke from there.