macos: Give entitlement com.apple.security.network.client #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To let the app make network requests: https://docs.flutter.dev/development/platform-integration/macos/building#setting-up-entitlements As suggested in the above-linked doc, make identical changes to both entitlements files.
|
Thanks! Looks good; merging. |
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this pull request
Jul 19, 2025
I happened to notice this message getting printed repeatedly in the
debug logs (reformatted a bit):
[ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception:
NetworkException: HTTP request failed. Client is already closed.
(ClientException: HTTP request failed. Client is already closed.,
uri=https://chat.zulip.org/api/v1/users/me/presence)
#0 ApiConnection.send (package:zulip/api/core.dart:175)
<asynchronous suspension>
zulip#1 Presence._maybePingAndRecordResponse (package:zulip/model/presence.dart:93)
<asynchronous suspension>
zulip#2 Presence._poll (package:zulip/model/presence.dart:121)
<asynchronous suspension>
That'd be a symptom of an old Presence continuing to run its polling
loop after the ApiConnection has been closed, which happens when the
PerAccountStore is disposed. Looks like when we introduced Presence
in 5d43df2 (zulip#1619), we forgot to call its `dispose` method.
Fix that now.
The presence model doesn't currently have any tests. So rather than
try to add a test for just this, we'll leave it as something to
include when we write those tests, zulip#1620.
chrisbobbe
pushed a commit
that referenced
this pull request
Jul 22, 2025
I happened to notice this message getting printed repeatedly in the
debug logs (reformatted a bit):
[ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception:
NetworkException: HTTP request failed. Client is already closed.
(ClientException: HTTP request failed. Client is already closed.,
uri=https://chat.zulip.org/api/v1/users/me/presence)
#0 ApiConnection.send (package:zulip/api/core.dart:175)
<asynchronous suspension>
#1 Presence._maybePingAndRecordResponse (package:zulip/model/presence.dart:93)
<asynchronous suspension>
#2 Presence._poll (package:zulip/model/presence.dart:121)
<asynchronous suspension>
That'd be a symptom of an old Presence continuing to run its polling
loop after the ApiConnection has been closed, which happens when the
PerAccountStore is disposed. Looks like when we introduced Presence
in 5d43df2 (#1619), we forgot to call its `dispose` method.
Fix that now.
The presence model doesn't currently have any tests. So rather than
try to add a test for just this, we'll leave it as something to
include when we write those tests, #1620.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To let the app make network requests:
https://docs.flutter.dev/development/platform-integration/macos/building#setting-up-entitlements
As suggested in the above-linked doc, make identical changes to both entitlements files.