-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spellchecker: Use Electron 8 built-in spellchecker. #967
Conversation
Just had a quick run - this works well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 bugs to keep updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code would've been much shorter if the package ISO-639-1 had corresponding names for some of the locale codes from electron.
c1b20e4
to
f342fa0
Compare
Functionality is working for me. Almost mergable I suppose. |
fee38c2
to
8e15134
Compare
7b51920
to
9cbc332
Compare
Signed-off-by: Anders Kaseorg <[email protected]>
* It performs the appropriate operations * Provides suggestions for misspellings caught by electron's built-in spellchecker * Will be maintained by the organisation * Tag-input in Setings -> General -> Functionality to select max 3 languages (stored on disk) * Pass the languages to spellchecker, after fetching from disk Fixes: zulip#504
* Better type annotations * Use DOM manipulation instead of HTML generation * Internationalize strings * Use .map and .filter to avoid quadratic loop * source tagify.css from node_modules * declare @yaireo/tagify * Proper internationalization
* Passing correct parameters including contextMenuParams * Typecasting event: Event
462db7a
to
9a279e9
Compare
* Bug fix: broken customCSS * Improvement: set default spellcheck lang * Improvement: ensure spellchecker is set for every session * Bug fix: json.parse() cannot parse empty array string when all the langs are deselected
Merged. Thanks, everyone for working on this 🚀 |
This works well. There are a couple of minor things which we'll be adding as a follow-up. |
What's this PR do?
#928 takes away with it the context menu as so this PR implements a custom context menu
Inherits commit from #928 as it was needed
Screenshots?
You have tested this PR on:
Also fixes: #504