Openshift - datetime value handling #889
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the message template customization function had `dep_time` and `dep_id` parameters, the `deployment` dict was not populated with those fields previously.
timabbott
reviewed
Dec 2, 2025
| # To utilize Zulip's global times (https://zulip.com/help/global-times), | ||
| # uncomment the below function, and call it from format_deployment_message. | ||
| # def get_global_time(dt_str: str) -> str: | ||
| # return f"<time:{datetime.strptime(dt_str, '%Y-%m-%d %H:%M:%S %z').isoformat()}>" |
Member
There was a problem hiding this comment.
This won't work without datetime being imported. I think it's fine to have this function available and just unused by default with a comment.
II suggest you also can also put a copy of the datetime=>HTML helper we added in zerver.lib into the main zulip Python library so it can be used by integrations easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use only ISO 8601 formats with the
<time:>syntax, so we remove the previous comment recommending the usage of<time:dep_time>, and instead add a (commented-out) function that converts the datetime to the right format.How did you test this PR?
I did not.
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: