Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance overlapping mouse keys control (#23341) #404

Open
wants to merge 1 commit into
base: firmware24
Choose a base branch
from

Conversation

jxz12
Copy link

@jxz12 jxz12 commented Jan 10, 2025

Enhance the overlapping mouse key press acceleration (introduced in qmk#21494) with user preprocessor controls.

Description

Cherry-pick of the commit in QMK pull request qmk#23341

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Enhance the overlapping mouse key press acceleration (introduced in qmk#21494) with user preprocessor controls.
@github-actions github-actions bot added the core label Jan 10, 2025
@jxz12
Copy link
Author

jxz12 commented Jan 10, 2025

I am in contact with Mike Bates in Customer Service and our investigations revealed that this commit is needed to fix mouse key behaviour in Oryx.

I'm not sure what the proper procedure is for making a PR here (e.g. is firmware24 the correct target branch?) but I am happy to update the PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants