Zpm msg #33
Zpm msg #33
Conversation
|
I think we should merge it as soon as reviewed, and all all |
|
Could you grant me some rigths on this repo, so that I can handle issues, labels, request reviews... |
|
@desyncr wrote:
I think just having zpm check the environment is fine. |
|
You should have those rights already as you're a org member. I'm gonna see what's going on later. |
|
Current argument parsing is a bit rudimentary so we could look into it. |
I quit like it like that 😄 |
| free(hash); | ||
| } else { | ||
| printf("\n"); | ||
| if(zpm_has_color) { |
There was a problem hiding this comment.
Why the need to for this condition?
There was a problem hiding this comment.
- because bold relates to fancy output.
- because bold messes with cram 😕
| vsnprintf(msg, 256, fmt, arg); | ||
| if (type != ZPM_NONE) { | ||
| if(zpm_has_color) { | ||
| int color = type == ZPM_ERR ? 31 : 32; |
There was a problem hiding this comment.
sorry, I mostly pasted untested code from the issue, so while fixing I forgot that 😕
|
Well, we should be able to extend I think for now it's OK to use env vars, I'll keep on the backlog to investigate option parting libs. |
|
@fennecdjay Re: permissions, sorry my bad. I miss configured permissions for members. Now you should have write access. 👍 |
2 participants
It should benefit from something about in the README, like