Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alerts endpoints #93

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Add alerts endpoints #93

merged 6 commits into from
Dec 7, 2023

Conversation

jakubzehner
Copy link
Contributor

No description provided.

@jakubzehner jakubzehner linked an issue Dec 6, 2023 that may be closed by this pull request
Add (notification-less) alert endpoints #75
Closed
2 tasks
@jakubzehner jakubzehner requested review from Daxin18 and tchojnacki and removed request for Daxin18 December 6, 2023 20:17
tchojnacki
tchojnacki reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@tchojnacki tchojnacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should plan out the system of automatic alert triggering, e.g. from an untaken medication, since it was not actually a part of any task.

SensoBackend/Application/Modules/Alerts/GetAlertHistory.cs Outdated Show resolved Hide resolved
SensoBackend/Application/Modules/Alerts/CreateAlert.cs Outdated Show resolved Hide resolved
SensoBackend/Application/Modules/Alerts/Contracts/CreateAlertDto.cs Outdated Show resolved Hide resolved
@jakubzehner jakubzehner changed the title Draft: Add alerts endpoints Add alerts endpoints Dec 7, 2023
Daxin18
Daxin18 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@Daxin18 Daxin18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
I only left one nitpick regarding XML comment, but I don't think it's something we should worry about too much

SensoBackend/WebApi/Controllers/V1/AlertsController.cs Outdated Show resolved Hide resolved
@jakubzehner jakubzehner merged commit 49c72fc into main Dec 7, 2023
2 checks passed
@jakubzehner jakubzehner deleted the 75-add-notification-less-alert-endpoints branch December 7, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchojnacki tchojnacki tchojnacki approved these changes

@Daxin18 Daxin18 Daxin18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add (notification-less) alert endpoints
3 participants
@jakubzehner @tchojnacki @Daxin18