Remove prop types in production #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the webpack config change about ~5 times smaller. Not due to the other changes in here but, probably, by using the production versions of react and react-dom. |
realityking
force-pushed
the
remove-prop-types
branch
from
8240c18 to
7dff4ef
Compare
|
@zpao Could you take a look at this one? 🙇 |
|
Thanks for merging! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another piece from #49.
I decided to forgo the babel plugin because it doesn't seem to work right with babel 7. There are only two prop types so wrapping them manually is not a big deal.
Ideally - at least in theory - this would allow webpack to drop prop-types completely from a bundle if there's no other consumer of it. Even if that's not the case, it reduces bundle size a little.