Major overhaul: prepare for v3 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not perfect. In particular string intersections seem to be incompatible as a prop type, as user strings aren't recognized. Still need to generate CJS compatible build
Just going to say it's not worth it right now.
Note: the QR Codes generated are not identical. This seems to be due to the exact approach taken when encoding strings (leaving encoding to the third-party lib again). If there are issues with Kanji or other multibyte strings, we'll need to revisit this decision, potentially fork this new lib or use it differently. https://www.nayuki.io/page/qr-code-generator-library
- use createRef for refs - convert QRCodeSVG to a function component (has no state)
Much like the SVG renderer, this gets rid of PureComponent and classes and goes to function components. This shouldn't matter in practice. Part of the reasoning was that getDerivedStateFromProps didn't give us what I needed, so we could get rid of state and simplify the logic. Now this actually checks the image element's status to determine if its loaded. In the process here, I was able to fix a bug to actually handle when images fail to load and excavation is set. Previously it would leave a whole in the middle, now it doesn't.
This - Moves the license out of the qrcodegen src file and into a standalone LICENSE - Adds copyright & spdx license headers to src files (https://spdx.dev/ids/) - Ensures license headers are preserved in the build output
This was
linked to
issues
Mar 6, 2022
Closed
This was referenced Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a massive overhaul, mostly as described in #169. In short: