Add description to ChannelPluginCompletionStatus #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jam0128 @intoxicated Can you review this when you have a time 🙏 |
|
@jam0128 @intoxicated Can you review this? 🙏 |
|
@konifar I think it will break objective-c compatibility :/ |
jam0128
force-pushed
the
master
branch
2 times, most recently
from
4c82595 to
9d10c86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added
descriptiontoChannelPluginCompletionStatusChannelPluginCompletionStatusis int enum. If the plugin user wants to show log when Channel IO fails to boot, they have to convert enum to string by themselves.