-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failure to activate in empty workspace #2002
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportBase: 74.44% // Head: 74.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
==========================================
+ Coverage 74.44% 74.46% +0.01%
==========================================
Files 63 63
Lines 7129 7130 +1
Branches 1543 1543
==========================================
+ Hits 5307 5309 +2
+ Misses 1815 1814 -1
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Signed-off-by: Timothy Johnson <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @t1m0thyj
Proposed changes
Fixes #1994 which is related to microsoft/vscode#96111. When an empty workspace is open in VS Code, then
vscode.workspace.workspaceFolders = [undefined]
which we weren't handling correctly.Release Notes
Milestone: 2.4.1
Changelog: Updated in the PR
Types of changes
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments
Here's how to create an empty workspace to test this PR. After saving the workspace, you can reopen the
.workspace
file to reproduce the issue.