Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to activate in empty workspace #2002

Merged
merged 6 commits into from
Nov 14, 2022
Merged

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Nov 7, 2022

Proposed changes

Fixes #1994 which is related to microsoft/vscode#96111. When an empty workspace is open in VS Code, then vscode.workspace.workspaceFolders = [undefined] which we weren't handling correctly.

Release Notes

Milestone: 2.4.1

Changelog: Updated in the PR

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Here's how to create an empty workspace to test this PR. After saving the workspace, you can reopen the .workspace file to reproduce the issue.
ze-fix-empty-workspace

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 74.44% // Head: 74.46% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b08de47) compared to base (720e8e0).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2002      +/-   ##
==========================================
+ Coverage   74.44%   74.46%   +0.01%     
==========================================
  Files          63       63              
  Lines        7129     7130       +1     
  Branches     1543     1543              
==========================================
+ Hits         5307     5309       +2     
+ Misses       1815     1814       -1     
  Partials        7        7              
Impacted Files Coverage Δ
packages/zowe-explorer/src/extension.ts 38.31% <0.00%> (-0.08%) ⬇️
packages/zowe-explorer/src/Profiles.ts 36.29% <80.00%> (+0.20%) ⬆️
packages/zowe-explorer/src/ZoweExplorerExtender.ts 63.15% <100.00%> (ø)
packages/zowe-explorer/src/utils/ProfilesUtils.ts 68.06% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zFernand0 zFernand0 self-requested a review November 8, 2022 18:17
@zFernand0 zFernand0 added this to the 2.4.1 milestone Nov 8, 2022
@t1m0thyj t1m0thyj marked this pull request as ready for review November 9, 2022 16:38
zFernand0
zFernand0 previously approved these changes Nov 14, 2022
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @t1m0thyj

@JillieBeanSim JillieBeanSim merged commit d4ddbef into main Nov 14, 2022
@JillieBeanSim JillieBeanSim deleted the fix-empty-workspace branch November 14, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refreshAll error showing with trees
3 participants