Lock down Rust version across all workflows #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
zFernand0
approved these changes
Jul 6, 2022
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 390 390
Lines 6209 6209
Branches 910 910
=======================================
Hits 5713 5713
Misses 490 490
Partials 6 6 Continue to review full report at Codecov.
|
Signed-off-by: Timothy Johnson <[email protected]>
KevinLoesch1
approved these changes
Jul 7, 2022
awharn
approved these changes
Jul 7, 2022
|
Waiting for new version of imperative before merging 😋 |
gejohnston
approved these changes
Jul 7, 2022
Signed-off-by: Timothy Johnson <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1466
Until the issue in Rust 1.62 is fixed, we don't want to accidentally publish new daemon binaries with broken behavior, so locking down the versions should keep us safe.
The Windows and macOS daemon builds weren't invoking the
actions-rs/toolchainaction, but probably should be to ensure that the daemon is built using the same Rust version across all platforms.Also automates running the Clippy linter so we don't have to remember to do it locally.