Skip to content

Fix stale thread focus and trim lower README screenshots - #4

Merged
zortos293 merged 1 commit into
mainfrom
agent/fix-stale-focus-and-readme-images
Jul 27, 2026
Merged

Fix stale thread focus and trim lower README screenshots#4
zortos293 merged 1 commit into
mainfrom
agent/fix-stale-focus-and-readme-images

Conversation

@zortos293

@zortos293 zortos293 commented Jul 27, 2026

Copy link
Copy Markdown
Owner

What changed

  • classify stopped T3 sessions as completed
  • move focus away from historical or settled threads when active work exists
  • clear stale detail, task, activity, and context state when focus changes or disappears
  • remove all README image embeds at and below the Control panel section while retaining the explanatory text and source assets

Why

T3Notch could remain focused on a stopped historical thread and display Idle while another agent was running. The README also had more screenshots than desired below the control-panel section.

Validation

  • all 31 Swift tests pass
  • added regression coverage for stopped sessions and stale-focus reconciliation
  • git diff --check passes
  • confirmed no image embeds remain below the Control panel heading

Summary by CodeRabbit

  • Improvements

    • Improved thread selection so focus remains on the active conversation when possible and moves automatically when it is no longer available.
    • Prevented outdated thread details from appearing after switching conversations.
    • Improved recognition of completed sessions, including stopped sessions without a latest turn.
  • Documentation

    • Removed onboarding screenshots while retaining the written walkthrough and guidance.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6c8fd260-2939-48b6-9d8f-098f4951c4d8

📥 Commits

Reviewing files that changed from the base of the PR and between c8b2e0e and 651dea1.

📒 Files selected for processing (4)
  • README.md
  • Sources/T3Notch/AgentStore.swift
  • Sources/T3NotchCore/Derivations.swift
  • Tests/T3NotchCoreTests/DerivationTests.swift

📝 Walkthrough

Walkthrough

AgentStore focus changes now share centralized transport and detail-reset handling. Focus preference and stopped-session completion logic were added to core derivations with tests. README walkthrough screenshots were removed while explanatory text was retained.

Changes

Thread focus and awareness

Layer / File(s) Summary
Awareness and focus derivation
Sources/T3NotchCore/Derivations.swift, Tests/T3NotchCoreTests/DerivationTests.swift
Stopped sessions are classified as completed, and preferred focus selection preserves active focus or chooses the first active thread, with coverage for historical, active, and empty-thread cases.
Centralized AgentStore focus flow
Sources/T3Notch/AgentStore.swift
Review dismissal, manual selection, and shell snapshot application use shared focus replacement, transport synchronization, detail reset, and matching-detail guards.

README walkthrough cleanup

Layer / File(s) Summary
Remove launch walkthrough screenshots
README.md
First-launch, connection-test, and finished-agent screenshots are removed while the surrounding explanatory text remains.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant AgentStore
  participant Derivations
  participant Transport
  participant DetailStream
  AgentStore->>Derivations: Select preferred focused thread
  Derivations-->>AgentStore: Return active thread ID
  AgentStore->>Transport: Update focused thread
  AgentStore->>DetailStream: Reset and subscribe to focused detail
  DetailStream-->>AgentStore: Apply matching detail snapshot
Loading
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-stale-focus-and-readme-images

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zortos293
zortos293 marked this pull request as ready for review July 27, 2026 17:13
@zortos293
zortos293 merged commit a40b282 into main Jul 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant