Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path update for helm charts #749

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

acelinkio
Copy link
Collaborator

relates to #747 updates the helm chart to specify paths and avoid the need for rewrite rules.

@acelinkio
Copy link
Collaborator Author

@zoriya , i can change the target for this MR to your feature branch if you'd like. note that this will pull in some changes from master branch.

I don't exactly follow why the /video path needs to be specified in the transcoder url. Eventually I'll get around to building/publishing the containers to test more locally.

@zoriya
Copy link
Owner

zoriya commented Jan 2, 2025

Some routes of the transcoder return URIs that should be reachable from the front (that was the previous use case of the GOCODER_PREFIX env var.) The c# back proxies this api under /video so we need to specify this prefix value (and it changes the listen route to include this prefix.)
On v5, the transcoder will be accessed directly without the proxy so it will be less weird x)

PS: you can keep targeted to master, i'll merge the PR branch soon. I just wanna test a bit more & see if it would break https://github.com/arthi-chaud/meelo to merge it like that.

@acelinkio acelinkio merged commit aadf300 into zoriya:master Jan 3, 2025
13 checks passed
@zoriya zoriya added this to the v4.7.1 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants