Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Helm Chart: map resources, livenessProbe and readinessProbe properties correctly in deployments #714

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

scme0
Copy link
Contributor

@scme0 scme0 commented Dec 13, 2024

I was fiddling around with the resources property on the transcode deployment and I noticed that the chart would fail to apply.

I found a few other properties with the same issue so I took the liberty of adjusting them too. I haven't made a thorough search to find any other properties that have this issue.

@scme0 scme0 requested a review from acelinkio as a code owner December 13, 2024 18:59
@acelinkio
Copy link
Collaborator

Looks good! Tested locally and verified the fix with the following values.

autosync:
  kyoo_autosync:
    resources:
      requests:
        memory: "64Mi"
        cpu: "250m"
      limits:
        memory: "128Mi"
        cpu: "500m"
    readinessProbe:
      httpGet:
        path: /healthz
        port: 8080
        httpHeaders:
        - name: Custom-Header
          value: Awesome
      initialDelaySeconds: 3
      periodSeconds: 3
    livenessProbe:
      httpGet:
        path: /healthz
        port: 8080
        httpHeaders:
        - name: Custom-Header
          value: Awesome
      initialDelaySeconds: 3
      periodSeconds: 3

Thank you for the PR!

@acelinkio acelinkio merged commit 03992e1 into zoriya:master Dec 14, 2024
13 checks passed
@scme0 scme0 deleted the bug-in-transcoder-deployment branch December 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants