Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language variations #671

Merged

Conversation

felipemarinho97
Copy link
Contributor

Closes #670

@zoriya
Copy link
Owner

zoriya commented Nov 11, 2024

We might want to improve this by using smarter fallbacks (like falling back to pt if pt-bz is not available, or things like that).

@zoriya zoriya enabled auto-merge (squash) November 11, 2024 20:27
@zoriya zoriya changed the title chg: fix: add language variations and add deduplication code Add language variations Nov 11, 2024
@zoriya zoriya merged commit 8312c66 into zoriya:master Nov 11, 2024
12 checks passed
@felipemarinho97 felipemarinho97 deleted the fix/language-preference-with-variations branch November 12, 2024 13:00
@felipemarinho97
Copy link
Contributor Author

We might want to improve this by using smarter fallbacks (like falling back to pt if pt-bz is not available, or things like that).

I totally agree!

A fallback would be great, but at best the preferred language should be a priority list. For example, if a user is bilingual, he or she could select two or more languages. And the service would try the 1st, 2nd, and so on. This definition is general enough to serve as a fallback between pt and pt-BR as well.

I believe that's how Netflix works.

felipemarinho97 added a commit to felipemarinho97/Kyoo that referenced this pull request Nov 24, 2024
* Update Helm release postgresql to v16.1.2 (zoriya#676)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add language variations (zoriya#671)

Co-authored-by: Felipe Marinho <[email protected]>

* chg: feat: add support for ignoring directories with ".ignore" file

* chg: docs: add docs about ignoring dirs

* chg: refactor: use data-structures to avoid costly loops and parallelize delete

* Docs: Add docs for OpenID Connect configuration (zoriya#682)

* Update dotnet monorepo to 8.0.11 (zoriya#684)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Helm release rabbitmq to v15.0.6 (zoriya#683)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update skiasharp monorepo to 2.88.9 (zoriya#685)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency System.ComponentModel.Composition to v9 (zoriya#686)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set prefered playback language for language variations (ex: pt-BR)
2 participants