Fix audio segment miscount #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This technically works but it's slow af. |
zoriya
force-pushed
the
fix/audio-duration
branch
from
37921b8 to
16f0125
Compare
zoriya
force-pushed
the
fix/audio-duration
branch
from
703b745 to
b505019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio duration can be different from container's duration. This leads to miss count of segments and the player waits for it before ending the playback.
This read the audio duration from the packets instead.
note: ffprobe can't be used to get audio duration directly since some formats don't have this metadata (mkv for example).