-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zope.interface==4.5.0 is not installable on linux via pip via the canonical "zope-interface" name #124
Comments
If it helps, I know for sure it started happening no more than a few days ago: today's CI build was the first one to exhibit this behaviour. |
Bug in pip? TBH I didn't even realize It's curious that z.i 4.5.0 is missing the manylinux wheels. The release was made on Aug 19, and I don't think anyone went and removed any wheels from PyPI during the last week, so if you're only seeing the problem now, something else must be causing it -- a new pip or setuptools release perhaps? |
There was a new pip release four days ago, and it did change something with parsing filenames. |
I tried with an older pip version and it kept failing IIRC. It could be a PyPI release. |
https://www.python.org/dev/peps/pep-0503/ is what defines the normalization, btw. |
Yeah, I can reproduce with pip 9.0.1. |
Still, I don't think this problem is specific to zope.interface. I'm also getting failures if I try to do Packages publishing universal wheels might've masked this error, but |
Ok, I'll go and create an issue against pip. |
@immerrr Please link that issue here and then close this one. |
pypa/pip#5870 is the corresponding PIP issue. Closing. |
@tseaver should the missing wheels be uploaded for 4.5.0? |
I don't know how, but looking at the "Commits" page, it seems that Travis was not triggered for the "Preparing release 4.5.0" commit on 2018-04-19. The Travis builds page shows no builds between aed246c (just prior to that on 2018-04-19) and c2ff25a (on 2018-04-28). I will attempt to recreate the |
The "preparing release" commit message contains |
I just got the |
Ugh! How was the |
Based on the format of the commit messages, I'm guessing @icemac used [zest.releaser]
extra-message = [skip ci] I used to have that configuration, but I discovered that it broke building release wheels --- I think it was a BTrees release where I noticed it. Based on zopefoundation/BTrees#86 I don't think icemac has that configuration anymore (neither do I). |
Since they've just published additional wheels, causing hash failures: https://pypi.org/project/zope.interface/4.5.0/#files zopefoundation/zope.interface#124 (comment)
Since they've just published additional wheels, causing hash failures: https://pypi.org/project/zope.interface/4.5.0/#files zopefoundation/zope.interface#124 (comment)
@jamadden Your analysis is correct: the other day I removed Sorry for using it in the first place and causing so much extra work for you guys. |
The trick is to create a new branch, based on the release tag, and add one more commit to it. That commit should not have "[skip ci]" in the commit message, and it should drop the When the build is done that branch can be removed. |
Does zest.releaser support that? Can it be made default configuration? (Should we be using signed tags, for extra crypto sparkles? My GPG key is an old 1024-bit DSA and I don't think it's considered secure any more.) |
I've run into this via pipenv that canonicalizes all names, actually, but looks like it's reproducible with plain pip, too.
Here's how it looks in a freshly created virtualenv
zope.interface==4.5.0
zope-interface==4.5.0
To compare, 4.4.3 installs successfully via both
zope.interface
andzope-interface
:zope.interface==4.4.3
zope-interface==4.4.3
Here's an installation log with verbose flag:
pip install --verbose ...
Interestingly, the difference is probably in the fact that 4.4.3 has a wheel and 4.5.0 comes as a source distribution only. I've poked inside pip and looks like the failure with the tgz is when pip tries to extract version information from the filename
zope.interface-4.5.0
it tries to find the canonical name,zope-interface
, and fails thus marking the package as "Missing project version".The text was updated successfully, but these errors were encountered: