Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused setuptools install requirement #99

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Remove unused setuptools install requirement #99

merged 1 commit into from
Oct 10, 2024

Conversation

cjwatson
Copy link
Contributor

@cjwatson cjwatson commented Oct 6, 2024

No description provided.

@icemac
Copy link
Member

icemac commented Oct 7, 2024

@cjwatson setuptools is used in setup.py but we do not have a namespaced package here.
Besides the green tests are you really sure we do not need setuptools at all here?

@cjwatson
Copy link
Contributor Author

cjwatson commented Oct 7, 2024

I'm pretty sure. It would surely have to involve setuptools or pkg_resources being imported somewhere by the actual installed code.

@icemac icemac merged commit c1530fb into zopefoundation:master Oct 10, 2024
47 checks passed
@icemac
Copy link
Member

icemac commented Oct 10, 2024

Thank you for this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjwatson @icemac