Fix issues with Python 3.2 ResourceWarning workaround #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.2 is long since end-of-life, and the workaround produces an unhandled exception on Python 3.11: AttributeError: NoneType object has no attribute close
dataflake
approved these changes
Dec 6, 2022
|
I just released ZConfig 3.6.1 with these changes. |
|
Thank you! The new release works as expected. (I’ve just taken over as maintainer of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn’t seem that
socket.SocketErrorhas existed in the standard library in vaguely-recent memory. This causes an error like the following:It seems that
socket.errorwas intended instead.Furthermore,
syslog.socketwill beNonehere on Python 3.11, which causes another unhandled exception:Since the whole workaround is supposed to be for Python 3.2, which is long since end-of-life, the best approach seems to be to remove the workaround entirely.