Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make react-native-windows peer dependency optional #656

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

geraintwhite
Copy link
Contributor

In npm 7 and npm 8, npm audit fix will fail with Unable to resolve dependency tree if react-native-windows is not installed. As react-native-permissions works perfectly on mobile without react-native-windows, this should be an optional peer dependency.

Ref lugg/react-native-config#585

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta

@geraintwhite geraintwhite requested a review from zoontek as a code owner October 12, 2021 13:36
Copy link

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This peerDependency stuff is a build breaker and getting more and more important to get just right. I think this is the right approach here, for whatever that's worth @zoontek

@zoontek zoontek merged commit f4cc61b into zoontek:master Oct 12, 2021
@zoontek
Copy link
Owner

zoontek commented Oct 12, 2021

I agree with that, I will push a new version tomorrow, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants