Add Windows support #530

bzoz · 2020-10-12T12:28:57Z

Summary

Add support for Windows using react-native-windows.

This PR includes the necessary Windows files and changes to the docs.

Test Plan

Unfortunately, this implementation uses APIs not available in Windows build uses by Github Action. You can run tests manually, using the example app - using Appium and jest:

yarn appium
yarn test:windows

Checklist

I have tested this on a device and a simulator
I added the documentation in README.md
I mentioned this change in CHANGELOG.md
I updated the typed files (TS and Flow)
I added a sample use of the API in the example project (example/App.js)

Add support for react-native-windows.

zoontek · 2020-10-13T12:15:26Z

@bzoz Hi @bzoz and thanks, this is an incredible pull request!
I read the files and it seems really clean to me. I really would like to test it before merging it (and release it with the next major version - #522), but need to find a Windows device for it since I don't have any 😕

windows/README.md

bzoz · 2020-10-13T17:57:20Z

@zoontek you can use Windows evaluation VMs to test: https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/:

When setting up, make sure to up the CPU count and RAM for the VM.

In the VM, run Powershell as admin, and execute:

Set-ExecutionPolicy Unrestricted -Scope Process -Force; iex (New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/microsoft/react-native-windows/master/vnext/Scripts/rnw-dependencies.ps1')

Answer y to all questions, it will setup tools needed on Windows, etc.

Then run choco install git.install --params "/GitAndUnixToolsOnPath" --force, to get rm in the PATH as it is needed by the example install script.

Then, its just building and running the example, in another console (so it will refresh PATH variable):

git clone https://github.com/zoontek/react-native-permissions.git
cd react-native-permissions
git fetch origin pull/530/head:win
git checkout win
yarn
cd example
yarn
npx react-native run-windows

The last one will take some time to build stuff. The script will try to install the app on the VM, and it can timeout. If that happens, just rerun npx react-native run-windows - it will be fast, and you should see the app running. Some of the deps do not support Windows, so you wont get nice icons, but the app should work:

Co-authored-by: Alexander Sklar <[email protected]>

asklar · 2020-10-13T18:01:48Z

package.json

@@ -59,7 +61,8 @@
  },
  "peerDependencies": {
    "react": ">=16.8.6",
-    "react-native": ">=0.60.0"
+    "react-native": ">=0.60.0",
+    "react-native-windows": ">=0.62"


should this be in the module always? I forget where we landed on this @jonthysell @acoates-ms

asklar · 2020-10-13T18:04:41Z

@zoontek you can use Windows evaluation VMs to test: https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/:

When setting up, make sure to up the CPU count and RAM for the VM.

In the VM, run Powershell as admin, and execute:
Set-ExecutionPolicy Unrestricted -Scope Process -Force; iex (New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/microsoft/react-native-windows/master/vnext/Scripts/rnw-dependencies.ps1')
Answer y to all questions, it will setup tools needed on Windows, etc.

Then run choco install git.install --params "/GitAndUnixToolsOnPath" --force, to get rm in the PATH as it is needed by the example install script.

Then, its just building and running the example, in another console (so it will refresh PATH variable):
git clone https://github.com/zoontek/react-native-permissions.git
cd react-native-permissions
git fetch origin pull/530/head:win
git checkout win
yarn
cd example
yarn
npx react-native run-windows
The last one will take some time to build stuff. The script will try to install the app on the VM, and it can timeout. If that happens, just rerun npx react-native run-windows - it will be fast, and you should see the app running. Some of the deps do not support Windows, so you wont get nice icons, but the app should work:

@bzoz @zoontek you can also use Windows Sandbox instead of setting up the VM (though you'll still have to install the dev dependencies)

rectified95 · 2020-10-13T18:20:57Z

windows/RNPermissions/RNPermissions.vcxproj

@@ -0,0 +1,163 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project DefaultTargets="Build" ToolsVersion="16.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="$(SolutionDir)\packages\Microsoft.Windows.CppWinRT.2.0.200316.3\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(SolutionDir)\packages\Microsoft.Windows.CppWinRT.2.0.200316.3\build\native\Microsoft.Windows.CppWinRT.props')" />


I think this should be: $(SolutionDir)packages -> no slash after the env variable. Have you also tried consuming the module in a new app, other than the existing example in this repo? (Unless we have changed/fixed the trailing slash)
Ref:
react-native-checkbox/react-native-checkbox@e94ba09

I've based that on https://github.com/react-native-community/react-native-camera/blob/master/windows/ReactNativeCameraCPP/ReactNativeCameraCPP.vcxproj, tested it and it works.

rectified95

Awesome! Just make sure you can consume this from a clean app before merging.

zoontek · 2020-10-16T12:36:18Z

Unfortunately, I'm only have my work computer with multiple iOS and Android SDKs installed and not enough space for this 😕

I have an old NUC (Gigabyte BRIX w. Celeron N2807) without hard drive. I will buy a small SSD.
Performances will be horrible, but it should be enough to test and maintain it. 😅

src/module.windows.ts

src/constants.ts

…the code

bzoz · 2020-10-20T11:53:21Z

@zoontek updated, PTAL

zoontek · 2020-10-23T07:56:50Z

@bzoz Tested again, everything seems OK now. Thanks

Add Windows support

a32c591

Add support for react-native-windows.

bzoz requested a review from zoontek as a code owner October 12, 2020 12:28

bzoz mentioned this pull request Oct 13, 2020

Support react-native-permissions microsoft/react-native-windows#5172

Closed

2 tasks

asklar reviewed Oct 13, 2020

View reviewed changes

windows/README.md Outdated Show resolved Hide resolved

asklar reviewed Oct 13, 2020

View reviewed changes

windows/README.md Outdated Show resolved Hide resolved

fixup: update README.md

aa17240

Co-authored-by: Alexander Sklar <[email protected]>

asklar reviewed Oct 13, 2020

View reviewed changes

asklar approved these changes Oct 13, 2020

View reviewed changes

rectified95 reviewed Oct 13, 2020

View reviewed changes

rectified95 approved these changes Oct 13, 2020

View reviewed changes

zoontek requested changes Oct 18, 2020

View reviewed changes

src/module.windows.ts Outdated Show resolved Hide resolved

src/module.windows.ts Outdated Show resolved Hide resolved

src/constants.ts Outdated Show resolved Hide resolved

bzoz added 4 commits October 20, 2020 11:26

fixup: update the permission list, use the same style as the rest of …

0255819

…the code

fixup: add a script to autoupdate the Windows permissions list

828679e

fixup: fix checkMultiple

7ea8d0c

fixup: fix requestMultiple

a9882a9

zoontek approved these changes Oct 23, 2020

View reviewed changes

zoontek merged commit d969b46 into zoontek:master Oct 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Windows support #530

Add Windows support #530

bzoz commented Oct 12, 2020

zoontek commented Oct 13, 2020 •

edited

Loading

bzoz commented Oct 13, 2020

asklar Oct 13, 2020

asklar commented Oct 13, 2020

rectified95 Oct 13, 2020 •

edited

Loading

bzoz Oct 13, 2020

rectified95 left a comment

zoontek commented Oct 16, 2020

bzoz commented Oct 20, 2020

zoontek commented Oct 23, 2020

Add Windows support #530

Add Windows support #530

Conversation

bzoz commented Oct 12, 2020

Summary

Test Plan

Checklist

zoontek commented Oct 13, 2020 • edited Loading

bzoz commented Oct 13, 2020

asklar Oct 13, 2020

Choose a reason for hiding this comment

asklar commented Oct 13, 2020

rectified95 Oct 13, 2020 • edited Loading

Choose a reason for hiding this comment

bzoz Oct 13, 2020

Choose a reason for hiding this comment

rectified95 left a comment

Choose a reason for hiding this comment

zoontek commented Oct 16, 2020

bzoz commented Oct 20, 2020

zoontek commented Oct 23, 2020

zoontek commented Oct 13, 2020 •

edited

Loading

rectified95 Oct 13, 2020 •

edited

Loading