Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Xcode 12 compatibility #519

Merged
merged 1 commit into from
Sep 21, 2020
Merged

fix: Xcode 12 compatibility #519

merged 1 commit into from
Sep 21, 2020

Conversation

Fetten
Copy link
Contributor

@Fetten Fetten commented Sep 18, 2020

Summary

The latest Xcode 12 fails to build when a module does not depend on React-Core directly. This change is necessary for all native modules on iOS. For details please see: facebook/react-native#29633 (comment)

Test Plan

  1. Build an App with Xcode 11.x. Result: The app builds.
  2. Build an App with Xcode 12. Result: The app will not build when depending on React.
  3. Build an App with Xcode 12 with the PR changes applied. Result: The app builds.

What's required for testing (prerequisites)?

Mac OS with Xcode 12

What are the steps to reproduce (after prerequisites)?

see Test Plan

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

The latest Xcode 12 fails to build when a module does not depend on `React-Core` directly. This change is necessary for all native modules on iOS. For details please see: facebook/react-native#29633 (comment)
@Fetten Fetten requested a review from zoontek as a code owner September 18, 2020 11:24
@radko93
Copy link

radko93 commented Sep 18, 2020

There are multiple podspecs in this repo so I'm not sure this is enough.

@Fetten
Copy link
Contributor Author

Fetten commented Sep 18, 2020

There are multiple podspecs in this repo so I'm not sure this is enough.

@radko93 Yes, there are, but none depends on React. Instead they use the main RNPermissions.podspec as dependency. My tests with Xcode 12 also went all fine.

@zoontek
Copy link
Owner

zoontek commented Sep 21, 2020

Thanks! I will release a new version.

@zoontek zoontek merged commit 69e1786 into zoontek:master Sep 21, 2020
@geraintwhite
Copy link
Contributor

Note that this change makes the minimum react-native version 0.60.2 th3rdwave/react-native-safe-area-context#147

@mikehardy
Copy link

I honestly have no idea how anyone can use RN60 productively any more. Doesn't this library already not support RN59?

@zoontek
Copy link
Owner

zoontek commented Sep 21, 2020

@mikehardy You can use with manual link of the core + CocoaPods for the handlers + jetifier -r on Android.
I will update the README to drop the support of RN 0.60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants