Support iOS 14 photo permission API changes #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zoontek Hello! We'd like to use this fix! Having this merged would be awesome! |
zoontek
reviewed
Sep 23, 2020
| @@ -23,14 +31,30 @@ - (void)checkWithResolver:(void (^ _Nonnull)(RNPermissionStatus))resolve | |||
| return resolve(RNPermissionStatusDenied); | |||
| case PHAuthorizationStatusAuthorized: | |||
| return resolve(RNPermissionStatusAuthorized); | |||
| case PHAuthorizationStatusLimited: | |||
There was a problem hiding this comment.
PHAuthorizationStatusLimited is not available on iOS < 14, no?
There was a problem hiding this comment.
I've tested it on simulator and works on both iOS 14 and iOS 13 without problems!
There was a problem hiding this comment.
The simulator might not work correctly on iOS because, unlike Android, it's not a proper emulator. Have you tested it on a real device?
There was a problem hiding this comment.
11 tasks
|
@jochem725 Sorry for the delay, and thanks for that fantastic work! I merged it in the upcoming 3.0.0 version branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
iOS 14 comes with some photo permission API changes that impact behavior for apps using this library.
→ Permissions are now split in “ReadWrite” and “AddOnly” permissions, so read permission is not always necessary.
→ Users can now grant “limited” permission, allowing them to pick which photos to share.
I’ve implemented both of these changes in the following way:
→ Updated the PhotoLibrary pod to make use of the new API, asking for “ReadWrite” permission (which is the old behavior)
→ Added PhotoLibraryAddOnly pod which asks AddOnly permission, (it behaves like a subset of ReadWrite, if ReadWrite is granted AddOnly is also granted)
→ When limited permission is given users can use a new method
presentLimitedLibraryPickerto summon the limited selection picker to update the selection. This is a no-op if users give access to their full library. By making it a separate method library users are flexible when to show it (i.e. make it available via a button so users can update their shared photo subset at any time)Impacts only iOS.
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)