Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security updates #38

Closed
wants to merge 2 commits into from
Closed

Security updates #38

wants to merge 2 commits into from

Conversation

eatyourgreens
Copy link
Contributor

Upgrade packages via npm audit fix.

@eatyourgreens
Copy link
Contributor Author

Updating zuul breaks the tests 😢.

@eatyourgreens
Copy link
Contributor Author

localtunnel.me is unreliable, which is causing the test failures. See defunctzombie/zuul#251

Upgrade packages via `npm audit fix`.
@eatyourgreens
Copy link
Contributor Author

So, I set the concurrent builds to 1 in Travis, for this repo, then just hit the rebuild button on failing builds until the tests ran. 🤷‍♂️

@srallen
Copy link
Contributor

srallen commented Jun 22, 2018

phantom.js is also a dead project now. I can't get packages to install. The phantom.js dependency install fails. We should probably remove zuul and phantom.js entirely. I'll give it a go to try getting jsdom working instead.

@srallen
Copy link
Contributor

srallen commented Jun 22, 2018

Looking over the tests, I don't think jsdom will be sufficient because there are some positioning tests and I think those will need rendering. Looking into puppeteer instead.

@srallen
Copy link
Contributor

srallen commented Jun 22, 2018

Or it'd probably work with JSDOM rewriting the tests to use enzyme.

@srallen
Copy link
Contributor

srallen commented Jun 22, 2018

Either one would potentially be a lot of work that I'm not sure is worth it since the API design of this library isn't great for what we mostly use it for. It might be worth looking for replacements. Grommet 2 components for modals, tooltips, or other libraries for those kinds of elements.

@eatyourgreens
Copy link
Contributor Author

I'm going to close this in favour of removing zuul.

@srallen srallen deleted the audit branch February 11, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants