-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security updates #38
Security updates #38
Conversation
Updating zuul breaks the tests 😢. |
|
Upgrade packages via `npm audit fix`.
So, I set the concurrent builds to 1 in Travis, for this repo, then just hit the rebuild button on failing builds until the tests ran. 🤷♂️ |
phantom.js is also a dead project now. I can't get packages to install. The phantom.js dependency install fails. We should probably remove zuul and phantom.js entirely. I'll give it a go to try getting jsdom working instead. |
Looking over the tests, I don't think jsdom will be sufficient because there are some positioning tests and I think those will need rendering. Looking into puppeteer instead. |
Or it'd probably work with JSDOM rewriting the tests to use enzyme. |
Either one would potentially be a lot of work that I'm not sure is worth it since the API design of this library isn't great for what we mostly use it for. It might be worth looking for replacements. Grommet 2 components for modals, tooltips, or other libraries for those kinds of elements. |
I'm going to close this in favour of removing zuul. |
Upgrade packages via
npm audit fix
.