Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid main field in package.json #96

Merged
merged 5 commits into from
Jul 15, 2021
Merged

Conversation

Vikasg7
Copy link
Contributor

@Vikasg7 Vikasg7 commented Jun 23, 2021

Fixed package.json for following warning.

(node:6644) [DEP0128] DeprecationWarning: Invalid 'main' field in 'E:\Desktop\Nodejs\XXXX-XXXX\node_modules\multi-hashing\package.json' of 'multihashing'. 
Please either fix that or report it to the module author
(Use `node --trace-deprecation ...` to show where the warning was created)

@Vikasg7
Copy link
Contributor Author

Vikasg7 commented Jun 23, 2021

@zone117x Could you please merge this when you have time? It will take away that warning from all the project which use this repo as a dependency.
Thanks!

@Vikasg7
Copy link
Contributor Author

Vikasg7 commented Jun 24, 2021

Fixed Error: Module did not self-register. ERR_DLOPEN_FAILED when requireing the module twice in the project.
More explanation on this error here.
Fix was suggested here

P.S.
Applied work around is suggested in following links:
nodejs/nan#844
https://github.com/nodejs/nan/blob/master/nan.h#L158

@zone117x
Copy link
Owner

Looks like this is failing to build or pass tests

@zone117x
Copy link
Owner

Looks like the scryptjane test vectors are failing. Is this related to the algo having some time component where it no longer works with a current date? Perhaps the that test should be disabled.

@Vikasg7
Copy link
Contributor Author

Vikasg7 commented Jul 15, 2021

Not sure about scrypt jane, ScriptJane tests were already failing before I made my changes.

@zone117x
Copy link
Owner

Not sure about scrypt jane, ScriptJane tests were already failing before I made my changes.

Can you just disable the scrypt jane tests in your PR and then we can ensure everything else passes and we can merge.

Copy link
Owner

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vikasg7!

@zone117x zone117x merged commit 27dd90e into zone117x:master Jul 15, 2021
@Vikasg7
Copy link
Contributor Author

Vikasg7 commented Jul 15, 2021

Thanks for merging this.

@github-actions
Copy link

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants