New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove round in the same transaction as getting it #168

Open

Kukunin wants to merge 1 commit into zone117x:master from Kukunin:unlocker-race-condition

Kukunin commented Jun 21, 2017

It avoid race condition when multiple blockUnlockers instances are running, and they add the reward multiple times.

Before this, two instances might both have taken the same round information, remove it and adds the same reward twice, which ruins the statistic.


          Remove round in the same transaction as getting it

2b09a40

It avoid race condition when multiple blockUnlockers are running

Author

Kukunin commented Jun 21, 2017

This code isn't tested, as there is no automatic tests suit and also I don't know the best way to test it.

Please review and give me your opinion on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment