enhance the scrolling experience. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecuvii
requested changes
Mar 25, 2025
|
@foru17 you did not add any styling to the scrollbar, I've appended a commit adding the missing styles Google.Chrome.hp6iZNyB.mp4 |
|
👀 So weird |
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to enhance the scrolling experience by integrating Radix UI's ScrollArea components into the layout. Key changes include:
- Importing and integrating ScrollArea components to wrap the main content.
- Setting up a custom vertical scrollbar with specific styling.
- Adjusting the layout hierarchy to accommodate the new scrolling structure.
Files not reviewed (2)
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
app/[locale]/layout.tsx:143
- [nitpick] The function name 'uwu' does not clearly communicate its purpose; consider renaming it to a more descriptive name.
function uwu() {
app/[locale]/layout.tsx:131
- Verify that the utility class 'before:size-full' is defined, as it is not a standard Tailwind CSS class and may lead to unintended styling issues.
<ScrollArea.Thumb className='relative flex-1 rounded-[10px] bg-stone-400 dark:bg-stone-600 before:absolute before:left-1/2 before:top-1/2 before:size-full before:min-h-11 before:min-w-11 before:-translate-x-1/2 before:-translate-y-1/2' />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.