Render ZAP1 attestation memos in transaction details#1680
Open
Zk-nd3r wants to merge 1 commit into
Open
Conversation
Parse ZAP1 prefix in shielded memo content, extract typed event fields, display as formatted card instead of raw hex.
Author
|
Cross-platform conformance suite added at github.com/Frontier-Compute/zap1/tree/main/contrib/zodl-conformance. Same 20+ test vectors for both platforms. Swift parser passes all vectors. Matches the Kotlin implementation in zodl-android #2173 exactly. Handles null-byte padded memos (real Zcash 512-byte format). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZAP1 memos in shielded transactions currently display as raw hex. This PR parses them into typed event cards.
What it does:
ZAP1:or0x5a41503109) in memo contentFiles:
Zap1MemoParser.swift- parser (matches the Kotlin implementation in zodl-android PR #2173)Zap1MemoParserTests.swift- XCTest coverageTransactionDetailsStore.swiftat line 434Verify any attestation: frontiercompute.cash/verify.html
Protocol spec: frontiercompute.cash/protocol.html
ZIP 1243: github.com/zcash/zips/pull/1243