remove filter::Context generic lifetime parameter #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi! Thanks for your submission :) I just fixed the linting, errors, could you rebase on master to check if the CI's green? |
VincentJousse
force-pushed
the
fix/filter-context-lifetimes
branch
from
bb5cf8f
to
1b49eca
Compare
|
Done ;) |
|
Would you rebase again? There were new clippy errors, seems that rust updates faster than I can fix lints... |
VincentJousse
force-pushed
the
fix/filter-context-lifetimes
branch
from
1b49eca
to
c2d4261
Compare
|
@Polochon-street Done again ! |
|
thanks! |
|
@Polochon-street just a reminder : this MR breaks the API !! Do you plan any release soon ? |
|
Unfortunately, that crate doesn't follow semver, so I can only release minor versions (otherwise the build script will try and fetch e.g. ffmpegv7.1 as far as I remember). I'll release a new version now :) |
|
it should be released now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #193