Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boards): add Bluemacro840 board #708

Closed
wants to merge 4 commits into from

Conversation

310weber
Copy link

@310weber 310weber commented Mar 1, 2021

feat: add support for BlueMacro840 board as "bluemacro840_v1"

  • reference (http://nrf52.jpconstantineau.com/docs/bluemacro840_v1/).

  • Board is similar to BlueMicro840 but has more GPIO pins available, and does not follow the ProMicro pinout.

  • Testing

    • Pass: Test compile using "m60" shield. Output to .uf2 file.
    • Pass: Load test zmk.uf2 to BlueMacro840 board (Adafruit bootloader). Drag-and-drop in Windows file manager.
    • Pass: Connect to Windows computer over USB and Bluetooth.
    • Untested: I do not have a functional shield to test with yet to confirm keyboard function.

@310weber
Copy link
Author

310weber commented Mar 1, 2021

Looking through the build errors it looks like they are all related to missing pro_micro references. Is this expected since the board I'm adding doesn't share the pro_micro form factor and pinout?

Common error messages:

  • ERROR (phandle_references): /kscan: Reference to non-existent node or label "pro_micro_a"
  • ERROR (phandle_references): /kscan: Reference to non-existent node or label "pro_micro_d"
  • Label or path pro_micro_i2c not found

@Nicell
Copy link
Member

Nicell commented Mar 1, 2021

Looking through the build errors it looks like they are all related to missing pro_micro references. Is this expected since the board I'm adding doesn't share the pro_micro form factor and pinout?

Our build script currently only tests Pro Micro board/shield pairings in the matrix. This board shouldn't be added to the same matrix since it doesn't fit in it. An explicit pairing should probably be added in the include section, although I don't know of any shield that goes with this board currently?

@310weber
Copy link
Author

310weber commented Mar 2, 2021

Looking through the build errors it looks like they are all related to missing pro_micro references. Is this expected since the board I'm adding doesn't share the pro_micro form factor and pinout?

Our build script currently only tests Pro Micro board/shield pairings in the matrix. This board shouldn't be added to the same matrix since it doesn't fit in it. An explicit pairing should probably be added in the include section, although I don't know of any shield that goes with this board currently?

Not that I'm aware of. I'm working on hand wiring my own.

@310weber 310weber changed the title Bluemacro840 Add Bluemacro840 board Mar 4, 2021
@310weber 310weber changed the title Add Bluemacro840 board feat(boards): add Bluemacro840 board Mar 4, 2021
@310weber
Copy link
Author

Our build script currently only tests Pro Micro board/shield pairings in the matrix. This board shouldn't be added to the same matrix since it doesn't fit in it. An explicit pairing should probably be added in the include section, although I don't know of any shield that goes with this board currently?

@Nicell - I added a commit moving the Bluemacro from the board/shield pairing matrix to the explicit includes section. It is currently not paired with any shields but there are other examples like that so I assume it's ok. Hopefully this cleans it up for anyone using this PR prior to the new board/shield system being implemented.

@dxmh dxmh added board PRs and issues related to boards. enhancement New feature or request labels Sep 23, 2021
@petejohanson
Copy link
Contributor

@310weber Are you still interested in getting this in? Needs an updated metadata file and build tweaks at least.

@310weber
Copy link
Author

@petejohanson Based on the lack of BlueMacro discussion on the Discord I'm guessing that not many other people are using it. I'd be ok to close this PR and just maintain support in my own zmk-config repo if that's preferred to minimize maintenance overhead in the main codebase.

@petejohanson
Copy link
Contributor

@petejohanson Based on the lack of BlueMacro discussion on the Discord I'm guessing that not many other people are using it. I'd be ok to close this PR and just maintain support in my own zmk-config repo if that's preferred to minimize maintenance overhead in the main codebase.

Yeah, seems fair to me. Happy to revisit if/when they become more popular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board PRs and issues related to boards. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants