-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(boards): add Bluemacro840 board #708
Conversation
Looking through the build errors it looks like they are all related to missing pro_micro references. Is this expected since the board I'm adding doesn't share the pro_micro form factor and pinout? Common error messages:
|
Our build script currently only tests Pro Micro board/shield pairings in the matrix. This board shouldn't be added to the same matrix since it doesn't fit in it. An explicit pairing should probably be added in the |
Not that I'm aware of. I'm working on hand wiring my own. |
@Nicell - I added a commit moving the Bluemacro from the board/shield pairing matrix to the explicit includes section. It is currently not paired with any shields but there are other examples like that so I assume it's ok. Hopefully this cleans it up for anyone using this PR prior to the new board/shield system being implemented. |
@310weber Are you still interested in getting this in? Needs an updated metadata file and build tweaks at least. |
@petejohanson Based on the lack of BlueMacro discussion on the Discord I'm guessing that not many other people are using it. I'd be ok to close this PR and just maintain support in my own zmk-config repo if that's preferred to minimize maintenance overhead in the main codebase. |
Yeah, seems fair to me. Happy to revisit if/when they become more popular. |
feat: add support for BlueMacro840 board as "bluemacro840_v1"
reference (http://nrf52.jpconstantineau.com/docs/bluemacro840_v1/).
Board is similar to BlueMicro840 but has more GPIO pins available, and does not follow the ProMicro pinout.
Testing