-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify behaviors by introducing behavior-state-changed event #532
Draft
okke-formsma
wants to merge
5
commits into
zmkfirmware:main
Choose a base branch
from
okke-formsma:refactor/behaviors-event
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Simplify behaviors by introducing behavior-state-changed event #532
okke-formsma
wants to merge
5
commits into
zmkfirmware:main
from
okke-formsma:refactor/behaviors-event
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okke-formsma
commented
Dec 19, 2020
6a08d3e
to
7f1b375
Compare
See #523. |
7f1b375
to
465f281
Compare
465f281
to
3a2407a
Compare
We currently have the following events
What is missing from this event flow are behavior bindings. This means they can not be observed like other events.
This PR adds the beahvior_state_changed event which is invoked just before an event is invoked. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype for a behavior-state-changed event, as suggested in #509
Please read this PR commit-by-commit. The last two commits are refactors of hold-taps and sticky-keys which show how this PR creates the ability to easily capture the behavior-state in behaviors.
I will "drip-feed" thse commits in in small pieces as well.