docs: move layer defines to reduce confusion #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the section about defines to the bottom, clearifing layer behaviors take a number as argument.
caksoylar
reviewed
Nov 13, 2024
caksoylar
reviewed
Nov 13, 2024
Co-authored-by: Cem Aksoylar <[email protected]>
caksoylar
approved these changes
Nov 13, 2024
|
Considering the rephrasing of the second sentence, can we link to sticky |
|
There is already some inconsistency regarding defining layer-tap here but not sticky layer, so ideally we'd do something similar where we define sticky layer here too. Also see #2273. I think the aforementioned can be done in the PR that'd handle #2273, for now maybe just a note like conditional layers would be great. As it tends to go: the more/better work you do, the more work we expect 😄 |
Nick-Munnich
approved these changes
Nov 20, 2024
|
We'll handle above in a separate PR. |
autoferrit
added a commit
to SpaceRockMedia/zmk
that referenced
this pull request
Dec 7, 2024
…johanson/zmk into petejohanson-feat/pointers-with-input-processors * 'feat/pointers-with-input-processors' of github.com:petejohanson/zmk: (186 commits) docs: Add initial pointer docs. feat: Add input split support. feat(mouse): Add mouse move and scroll support feat(boards): Update for mikoto board definition (zmkfirmware#1946) refactor(Kconfig): Extracted designer defaults out into new files (zmkfirmware#2537) chore(main): release 0.1.0 (zmkfirmware#2657) docs: Create a Hardware Integration index page (zmkfirmware#2634) docs: Mention combos in reset behaviors (zmkfirmware#2677) fix(boards): Disable uart serial node in Xiao BLE by default (zmkfirmware#2672) chore(deps): bump the prod-other-minor-patch group across 1 directory with 2 updates feat(boards): Add glove80 nexus node for extension GPIO. (zmkfirmware#2594) docs: Move defines to the end in layer behaviors (zmkfirmware#2639) docs: Update new-shield.mdx (zmkfirmware#2664) docs(ci): Netlify ignore command to check branch (zmkfirmware#2659) chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs feat(ci): Add release-please automation with VERSION (zmkfirmware#2622) docs: Remove dangling 0 in sticky keys docs fix: include a header file for RC macros (zmkfirmware#2649) feat(drivers): Support init high/low in 595 driver docs: touchups on the soft off information for improved clarity. (zmkfirmware#2647) ...
autoferrit
added a commit
to SpaceRockMedia/zmk
that referenced
this pull request
Dec 7, 2024
…fingerpunch * petejohanson-feat/pointers-with-input-processors: (186 commits) docs: Add initial pointer docs. feat: Add input split support. feat(mouse): Add mouse move and scroll support feat(boards): Update for mikoto board definition (zmkfirmware#1946) refactor(Kconfig): Extracted designer defaults out into new files (zmkfirmware#2537) chore(main): release 0.1.0 (zmkfirmware#2657) docs: Create a Hardware Integration index page (zmkfirmware#2634) docs: Mention combos in reset behaviors (zmkfirmware#2677) fix(boards): Disable uart serial node in Xiao BLE by default (zmkfirmware#2672) chore(deps): bump the prod-other-minor-patch group across 1 directory with 2 updates feat(boards): Add glove80 nexus node for extension GPIO. (zmkfirmware#2594) docs: Move defines to the end in layer behaviors (zmkfirmware#2639) docs: Update new-shield.mdx (zmkfirmware#2664) docs(ci): Netlify ignore command to check branch (zmkfirmware#2659) chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs feat(ci): Add release-please automation with VERSION (zmkfirmware#2622) docs: Remove dangling 0 in sticky keys docs fix: include a header file for RC macros (zmkfirmware#2649) feat(drivers): Support init high/low in 595 driver docs: touchups on the soft off information for improved clarity. (zmkfirmware#2647) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the section about defines to the bottom, clearifing layer behaviors take a number as argument.